From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53417)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZEgOg-0007dr-Nu
	for qemu-devel@nongnu.org; Mon, 13 Jul 2015 12:16:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZEgOc-00056t-Ka
	for qemu-devel@nongnu.org; Mon, 13 Jul 2015 12:16:02 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48629)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZEgOc-00056S-A4
	for qemu-devel@nongnu.org; Mon, 13 Jul 2015 12:15:58 -0400
References: <1436544486-31169-1-git-send-email-fred.konrad@greensocs.com>
	<1436544486-31169-3-git-send-email-fred.konrad@greensocs.com>
	<87si8sjbk9.fsf@linaro.org>
	<CAFEAcA8C7vMOHgUN2U8BRX8KzBG7uMh=EUYQYwRFqHeUvZM7WQ@mail.gmail.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <55A3E438.1010904@redhat.com>
Date: Mon, 13 Jul 2015 18:15:52 +0200
MIME-Version: 1.0
In-Reply-To: <CAFEAcA8C7vMOHgUN2U8BRX8KzBG7uMh=EUYQYwRFqHeUvZM7WQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH V2 2/3] cpus: add a tcg_executing flag.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, =?UTF-8?Q?Alex_Benn=c3=a9e?= <alex.bennee@linaro.org>
Cc: mttcg@greensocs.com, Mark Burton <mark.burton@greensocs.com>, Alvise Rigo <a.rigo@virtualopensystems.com>, QEMU Developers <qemu-devel@nongnu.org>, Guillaume Delbergue <guillaume.delbergue@greensocs.com>, =?UTF-8?B?S09OUkFEIEZyw6lkw6lyaWM=?= <fred.konrad@greensocs.com>



On 13/07/2015 18:10, Peter Maydell wrote:
>  (4) a few other things which are suspicious at best:
>   hw/intc/apic_common.c:    volatile int a_i_d = apic_irq_delivered;

This one has a comment above:

    /* Copy this into a local variable to encourage gcc to emit a plain
     * register for a sys/sdt.h marker.  For details on this workaround, see:
     * https://sourceware.org/bugzilla/show_bug.cgi?id=13296
     */

>   hw/xen/xen_pt_msi.c:        const volatile uint32_t *vec_ctrl;

Seems to be MMIO (yes, really), so okay.

Paolo