From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60110)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1ZEvnh-0003Zq-V9
	for qemu-devel@nongnu.org; Tue, 14 Jul 2015 04:42:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1ZEvnc-0007wo-T7
	for qemu-devel@nongnu.org; Tue, 14 Jul 2015 04:42:53 -0400
Received: from mga02.intel.com ([134.134.136.20]:49759)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tiejun.chen@intel.com>) id 1ZEvnc-0007w0-JU
	for qemu-devel@nongnu.org; Tue, 14 Jul 2015 04:42:48 -0400
Message-ID: <55A4CB84.90404@intel.com>
Date: Tue, 14 Jul 2015 16:42:44 +0800
From: "Chen, Tiejun" <tiejun.chen@intel.com>
MIME-Version: 1.0
References: <1436247191-13577-1-git-send-email-tiejun.chen@intel.com>
	<1436247191-13577-9-git-send-email-tiejun.chen@intel.com>
	<alpine.DEB.2.02.1507131711200.17378@kaball.uk.xensource.com>
	<20150713200122-mutt-send-email-mst@redhat.com>
In-Reply-To: <20150713200122-mutt-send-email-mst@redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [v9][PATCH 08/10] xen,
	gfx passthrough: register a isa bridge
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, ehabkost@redhat.com, rth@twiddle.net

>>> diff --git a/include/hw/xen/xen.h b/include/hw/xen/xen.h
>>> index 4356af4..703148e 100644
>>> --- a/include/hw/xen/xen.h
>>> +++ b/include/hw/xen/xen.h
>>> @@ -51,4 +51,5 @@ void xen_register_framebuffer(struct MemoryRegion *mr);
>>>   #  define HVM_MAX_VCPUS 32
>>>   #endif
>>>
>>> +extern void igd_passthrough_isa_bridge_create(PCIBus *bus, uint16_t gpu_dev_id);
>>>   #endif /* QEMU_HW_XEN_H */
>>
>> You are right that I was confused on my previous comment, but it is true
>> that it shouldn't be part of this patch: it should be part of patch

Right.

>> 7/10. Also the declaration should probably not be in the xen.h header.
>>
>> Michael, where do you think should go?
>
> Donnu - add a header?
>

What about the include/hw/i386/pc.h file?

Thanks
Tiejun