From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57546) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZF66V-0003VN-9j for qemu-devel@nongnu.org; Tue, 14 Jul 2015 15:43:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZF66U-0003gQ-6R for qemu-devel@nongnu.org; Tue, 14 Jul 2015 15:42:59 -0400 Message-ID: <55A56642.60006@redhat.com> Date: Tue, 14 Jul 2015 12:42:58 -0700 From: Josh Durgin MIME-Version: 1.0 References: <1433993326-26294-1-git-send-email-jdurgin@redhat.com> <5592DFC2.9060707@redhat.com> <20150709095920.GA28530@stefanha-thinkpad.redhat.com> <20150714142027.GA4219@noname.redhat.com> In-Reply-To: <20150714142027.GA4219@noname.redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 0/4] rbd cleanup and settings precedence fixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , Stefan Hajnoczi Cc: Jeff Cody , qemu-devel@nongnu.org, qemu-block@nongnu.org On 07/14/2015 07:20 AM, Kevin Wolf wrote: > Am 09.07.2015 um 11:59 hat Stefan Hajnoczi geschrieben: >> On Tue, Jun 30, 2015 at 11:28:18AM -0700, Josh Durgin wrote: >>> Ping >>> >>> On 06/10/2015 08:28 PM, Josh Durgin wrote: >>>> Patches 1 and 2 are simple cleanups. 3 and 4 fix the precedence of >>>> cache options and ceph settings. The cache option precedence in >>>> particular is important due to the potential for misconfigurations >>>> (ceph.conf setting rbd_cache=true, qemu setting cache=none) to >>>> accidentally put data at risk. >>>> >>>> Josh Durgin (4): >>>> rbd: remove unused constants and fields >>>> MAINTAINERS: update email address >>>> rbd: make qemu's cache setting override any ceph setting >>>> rbd: fix ceph settings precedence >>>> >>>> MAINTAINERS | 2 +- >>>> block/rbd.c | 64 +++++++++++++++++++++++++++++++++---------------------------- >>>> 2 files changed, 36 insertions(+), 30 deletions(-) >> >> This should go via Jeff: >> >> $ scripts/get_maintainer.pl -f block/rbd.c >> Josh Durgin (supporter:RBD) >> Jeff Cody (supporter:RBD) >> Kevin Wolf (supporter:Block layer core) >> qemu-block@nongnu.org (open list:RBD) >> >> Jeff is currently on vacation but will be back before the QEMU 2.4-rc1 >> tag is made. > > Considering that Josh is the primary maintainer for rbd and Jeff is just > merging patches for him, and that Jeff has already given R-b for patches > 1 to 3, and that Jeff doesn't seem to be back yet, and that the patches > look good to me, I'm taking this through my tree for -rc1. > > (I guess this is my longest "thanks, applied" sentence so far...) Thanks! Josh