From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48083) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFIjQ-00016C-Ug for qemu-devel@nongnu.org; Wed, 15 Jul 2015 05:12:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZFIjN-0006On-Fv for qemu-devel@nongnu.org; Wed, 15 Jul 2015 05:12:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40142) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFIjN-0006OV-Ab for qemu-devel@nongnu.org; Wed, 15 Jul 2015 05:11:57 -0400 Message-ID: <55A623D7.6080301@redhat.com> Date: Wed, 15 Jul 2015 17:11:51 +0800 From: Jason Wang MIME-Version: 1.0 References: <1436938201-16766-1-git-send-email-jasowang@redhat.com> <1436938201-16766-2-git-send-email-jasowang@redhat.com> <20150715110155.442078b5.cornelia.huck@de.ibm.com> In-Reply-To: <20150715110155.442078b5.cornelia.huck@de.ibm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V2 1/5] virtio: get_features() can fail List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, mst@redhat.com On 07/15/2015 05:01 PM, Cornelia Huck wrote: > On Wed, 15 Jul 2015 13:29:57 +0800 > Jason Wang wrote: > >> Signed-off-by: Jason Wang >> --- >> hw/9pfs/virtio-9p-device.c | 3 ++- >> hw/block/virtio-blk.c | 3 ++- >> hw/char/virtio-serial-bus.c | 3 ++- >> hw/display/virtio-gpu.c | 3 ++- >> hw/input/virtio-input.c | 3 ++- >> hw/net/virtio-net.c | 3 ++- >> hw/scsi/vhost-scsi.c | 3 ++- >> hw/scsi/virtio-scsi.c | 3 ++- >> hw/virtio/virtio-balloon.c | 3 ++- >> hw/virtio/virtio-bus.c | 3 ++- >> hw/virtio/virtio-rng.c | 2 +- >> include/hw/virtio/virtio.h | 4 +++- >> 12 files changed, 24 insertions(+), 12 deletions(-) >> diff --git a/hw/virtio/virtio-bus.c b/hw/virtio/virtio-bus.c >> index 3926f7e..febda76 100644 >> --- a/hw/virtio/virtio-bus.c >> +++ b/hw/virtio/virtio-bus.c >> @@ -54,7 +54,8 @@ void virtio_bus_device_plugged(VirtIODevice *vdev, Error **errp) >> >> /* Get the features of the plugged device. */ >> assert(vdc->get_features != NULL); >> - vdev->host_features = vdc->get_features(vdev, vdev->host_features); >> + vdev->host_features = vdc->get_features(vdev, vdev->host_features, >> + errp); >> } >> >> /* Reset the virtio_bus */ > Don't you need to propagate the error instead of passing it through? Or > am I just confused by error handling? :) > If I understand the code correctly. The caller (virtio_device_realize()) will propagate the error.