From: Laszlo Ersek <lersek@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/7] ipxe: rm local config in cleanup
Date: Wed, 15 Jul 2015 12:58:45 +0200 [thread overview]
Message-ID: <55A63CE5.8090006@redhat.com> (raw)
In-Reply-To: <1436955007-8216-4-git-send-email-kraxel@redhat.com>
On 07/15/15 12:10, Gerd Hoffmann wrote:
> ipxe build now generates empty local header files in case they are
> not preset.
ITYM "prese[n]t". (Although, pre-set seems to make some sense as well,
so I'm not fully sure.)
> Let's remove them on cleanup to make sure we store a
> fresh copy on the next build.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
> roms/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/roms/Makefile b/roms/Makefile
> index 7b3f156..c0153c7 100644
> --- a/roms/Makefile
> +++ b/roms/Makefile
> @@ -153,5 +153,6 @@ clean:
> $(MAKE) -C sgabios clean
> rm -f sgabios/.depend
> $(MAKE) -C ipxe/src veryclean
> + (cd ipxe; rm -f src/config/local/*.h)
> $(MAKE) -C SLOF clean
> rm -rf u-boot/build.e500
>
I'll let you decide about the (non-)typo.
Acked-by: Laszlo Ersek <lersek@redhat.com>
next prev parent reply other threads:[~2015-07-15 10:58 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 10:10 [Qemu-devel] [PATCH 0/7] ipxe update, continued Gerd Hoffmann
2015-07-15 10:10 ` [Qemu-devel] [PATCH 1/7] ipxe: update from 35c53797 to 24112d9 (upstream/master) Gerd Hoffmann
2015-07-15 10:51 ` Laszlo Ersek
2015-07-15 10:10 ` [Qemu-devel] [PATCH 2/7] ipxe: update to 87981bb (qemu) Gerd Hoffmann
2015-07-15 10:57 ` Laszlo Ersek
2015-07-15 10:10 ` [Qemu-devel] [PATCH 3/7] ipxe: rm local config in cleanup Gerd Hoffmann
2015-07-15 10:58 ` Laszlo Ersek [this message]
2015-07-15 10:10 ` [Qemu-devel] [PATCH 4/7] ipxe: disable load file protocol Gerd Hoffmann
2015-07-15 11:01 ` Laszlo Ersek
2015-07-15 10:10 ` [Qemu-devel] [PATCH 5/7] ipxe: add qemu branding Gerd Hoffmann
2015-07-15 11:02 ` Laszlo Ersek
2015-07-15 10:10 ` [Qemu-devel] [PATCH 6/7] ipxe: don't override GITVERSION Gerd Hoffmann
2015-07-15 11:06 ` Laszlo Ersek
2015-07-15 10:10 ` [Qemu-devel] [PATCH 7/7] ipxe: update binaries Gerd Hoffmann
2015-07-15 11:10 ` Laszlo Ersek
2015-07-15 12:01 ` Gerd Hoffmann
2015-07-15 12:58 ` Laszlo Ersek
2015-07-15 10:47 ` [Qemu-devel] [PATCH 0/7] ipxe update, continued Laszlo Ersek
2015-07-15 11:13 ` Laszlo Ersek
2015-07-16 15:22 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A63CE5.8090006@redhat.com \
--to=lersek@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).