From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56519)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1ZFKOp-0004n5-ET
	for qemu-devel@nongnu.org; Wed, 15 Jul 2015 06:58:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1ZFKOm-0007jg-8f
	for qemu-devel@nongnu.org; Wed, 15 Jul 2015 06:58:51 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44303)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1ZFKOm-0007jc-32
	for qemu-devel@nongnu.org; Wed, 15 Jul 2015 06:58:48 -0400
Received: from int-mx14.intmail.prod.int.phx2.redhat.com
	(int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27])
	by mx1.redhat.com (Postfix) with ESMTPS id 821B4347A62
	for <qemu-devel@nongnu.org>; Wed, 15 Jul 2015 10:58:47 +0000 (UTC)
Message-ID: <55A63CE5.8090006@redhat.com>
Date: Wed, 15 Jul 2015 12:58:45 +0200
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <1436955007-8216-1-git-send-email-kraxel@redhat.com>
	<1436955007-8216-4-git-send-email-kraxel@redhat.com>
In-Reply-To: <1436955007-8216-4-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/7] ipxe: rm local config in cleanup
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org

On 07/15/15 12:10, Gerd Hoffmann wrote:
> ipxe build now generates empty local header files in case they are
> not preset.

ITYM "prese[n]t". (Although, pre-set seems to make some sense as well,
so I'm not fully sure.)

> Let's remove them on cleanup to make sure we store a
> fresh copy on the next build.
> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  roms/Makefile | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/roms/Makefile b/roms/Makefile
> index 7b3f156..c0153c7 100644
> --- a/roms/Makefile
> +++ b/roms/Makefile
> @@ -153,5 +153,6 @@ clean:
>  	$(MAKE) -C sgabios clean
>  	rm -f sgabios/.depend
>  	$(MAKE) -C ipxe/src veryclean
> +	(cd ipxe; rm -f src/config/local/*.h)
>  	$(MAKE) -C SLOF clean
>  	rm -rf u-boot/build.e500
> 

I'll let you decide about the (non-)typo.

Acked-by: Laszlo Ersek <lersek@redhat.com>