From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57149)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1ZFKRO-0006tK-Lm
	for qemu-devel@nongnu.org; Wed, 15 Jul 2015 07:01:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1ZFKRK-0000ih-SG
	for qemu-devel@nongnu.org; Wed, 15 Jul 2015 07:01:30 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40157)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1ZFKRK-0000iS-NM
	for qemu-devel@nongnu.org; Wed, 15 Jul 2015 07:01:26 -0400
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (Postfix) with ESMTPS id 3B758C9B36
	for <qemu-devel@nongnu.org>; Wed, 15 Jul 2015 11:01:26 +0000 (UTC)
Message-ID: <55A63D84.8030105@redhat.com>
Date: Wed, 15 Jul 2015 13:01:24 +0200
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <1436955007-8216-1-git-send-email-kraxel@redhat.com>
	<1436955007-8216-5-git-send-email-kraxel@redhat.com>
In-Reply-To: <1436955007-8216-5-git-send-email-kraxel@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 4/7] ipxe: disable load file protocol
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On 07/15/15 12:10, Gerd Hoffmann wrote:
> Activate the opt-out added by one ipxe patch.

No need to designate the exact commit hash (it will change after the
next rebase), but I'd prefer if you referred to the ipxe patch by subject:

  [efi] make load file protocol optional

> 
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  roms/config.ipxe.general.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/roms/config.ipxe.general.h b/roms/config.ipxe.general.h
> index 619ee4c..2df042a 100644
> --- a/roms/config.ipxe.general.h
> +++ b/roms/config.ipxe.general.h
> @@ -2,3 +2,4 @@
>  #define BANNER_TIMEOUT 30
>  #undef ROM_BANNER_TIMEOUT
>  #define ROM_BANNER_TIMEOUT 0
> +#undef EFI_PROTO_LOAD_FILE
> 

With that commit message change:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>