From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50107) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFLUf-0001et-JS for qemu-devel@nongnu.org; Wed, 15 Jul 2015 08:08:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZFLUX-0007oZ-Ak for qemu-devel@nongnu.org; Wed, 15 Jul 2015 08:08:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33049) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFLUX-0007oP-5P for qemu-devel@nongnu.org; Wed, 15 Jul 2015 08:08:49 -0400 Message-ID: <55A64D4B.6020305@redhat.com> Date: Wed, 15 Jul 2015 14:08:43 +0200 From: Laszlo Ersek MIME-Version: 1.0 References: <1436905391-19262-1-git-send-email-wei@redhat.com> <1436905391-19262-5-git-send-email-wei@redhat.com> In-Reply-To: <1436905391-19262-5-git-send-email-wei@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [ARM SMBIOS RFC PATCH 4/5] smbios: move smbios code into a common folder List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wei Huang Cc: peter.maydell@linaro.org, drjones@redhat.com, ehabkost@redhat.com, mst@redhat.com, zhaoshenglong@huawei.co, qemu-devel@nongnu.org, imammedo@redhat.com, pbonzini@redhat.com, rth@twiddle.net On 07/14/15 22:23, Wei Huang wrote: > To share smbios among different architectures, this patch moves SMBIOS > code (smbios.c and smbios.h) from x86 specific folders into new > hw/smbios directories. As a result, CONFIG_SMBIOS=y is defined in > x86 default config files. > > Signed-off-by: Wei Huang > --- > arch_init.c | 2 +- > default-configs/i386-softmmu.mak | 1 + > default-configs/x86_64-softmmu.mak | 1 + > hw/Makefile.objs | 1 + > hw/i386/Makefile.objs | 2 +- > hw/i386/pc.c | 2 +- > hw/i386/pc_piix.c | 2 +- > hw/i386/pc_q35.c | 2 +- > hw/i386/smbios.c | 1102 ------------------------------------ > hw/smbios/Makefile.objs | 1 + > hw/smbios/smbios.c | 1102 ++++++++++++++++++++++++++++++++++++ > include/hw/i386/smbios.h | 237 -------- > include/hw/smbios/smbios.h | 237 ++++++++ > tests/bios-tables-test.c | 2 +- > vl.c | 2 +- > 15 files changed, 1350 insertions(+), 1346 deletions(-) > delete mode 100644 hw/i386/smbios.c > create mode 100644 hw/smbios/Makefile.objs > create mode 100644 hw/smbios/smbios.c > delete mode 100644 include/hw/i386/smbios.h > create mode 100644 include/hw/smbios/smbios.h Can you please send the next version of this series (I assume there's going to be one) with rename detection enabled? At least "hw/i386/smbios.c" --> "hw/smbios/smbios.c" appears a rename. A few lines may have changed, but without enabling rename detection, it's really hard to tell. Thanks Laszlo