From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34554) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFM64-0007C5-3N for qemu-devel@nongnu.org; Wed, 15 Jul 2015 08:47:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZFM63-0001zF-9O for qemu-devel@nongnu.org; Wed, 15 Jul 2015 08:47:36 -0400 References: <1436938201-16766-1-git-send-email-jasowang@redhat.com> <1436938201-16766-4-git-send-email-jasowang@redhat.com> <20150715151941-mutt-send-email-mst@redhat.com> From: Paolo Bonzini Message-ID: <55A6565C.2060509@redhat.com> Date: Wed, 15 Jul 2015 14:47:24 +0200 MIME-Version: 1.0 In-Reply-To: <20150715151941-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V2 3/5] virtio-blk: disable scsi passthrough by default List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Jason Wang Cc: kwolf@redhat.com, cornelia.huck@de.ibm.com, qemu-block@nongnu.org, qemu-devel@nongnu.org, stefanha@redhat.com On 15/07/2015 14:21, Michael S. Tsirkin wrote: >> > Disable scsi passthrough by default since it was incompatible with >> > virtio 1.0. For legacy machine types, keep this on by default. >> > >> > Cc: Stefan Hajnoczi >> > Cc: Kevin Wolf >> > Cc: qemu-block@nongnu.org >> > Signed-off-by: Jason Wang > Seems risky for 2.4. modern is off by default for now. Can't we limit > the change to when modern is enabled? That would have the effect of disabling a feature when you turn on modern. > I suggested changing this from bool to on/off/auto, and > make auto mean !modern. No, please do it like Jason did. The SCSI feature effectively had to be enabled explicitly already, the requests were marked as unsupported. Paolo