qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, lersek@redhat.com, qemu-devel@nongnu.org,
	stefanha@redhat.com, rjones@redhat.com
Subject: Re: [Qemu-devel] [PATCH] AioContext: fix broken ctx->dispatching optimization
Date: Thu, 16 Jul 2015 11:14:37 +0200	[thread overview]
Message-ID: <55A775FD.9060700@redhat.com> (raw)
In-Reply-To: <20150716052920.GA15296@ad.nay.redhat.com>



On 16/07/2015 07:29, Fam Zheng wrote:
>> This patch rewrites the ctx->dispatching optimization 
> 
> I lost track, but what was the justification of this optimization?

qemu_bh_schedule's call to aio_notify were showing in the profile as 20%
or so.

Paolo

> Anyway, awesome debugging and explanations!

  reply	other threads:[~2015-07-16  9:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-15 17:13 [Qemu-devel] [PATCH] AioContext: fix broken ctx->dispatching optimization Paolo Bonzini
2015-07-15 18:00 ` Laszlo Ersek
2015-07-15 20:14 ` Kevin Wolf
2015-07-15 22:59   ` Paolo Bonzini
2015-07-16  9:14     ` Kevin Wolf
2015-07-16  9:34       ` Paolo Bonzini
2015-07-16  5:29 ` Fam Zheng
2015-07-16  9:14   ` Paolo Bonzini [this message]
2015-07-16  9:16   ` Stefan Hajnoczi
2015-07-16 10:17 ` Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55A775FD.9060700@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=famz@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lersek@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rjones@redhat.com \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).