From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43561) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFfFd-0000aE-D2 for qemu-devel@nongnu.org; Thu, 16 Jul 2015 05:14:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZFfFa-0002xX-8M for qemu-devel@nongnu.org; Thu, 16 Jul 2015 05:14:45 -0400 Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:33224) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFfFa-0002xR-19 for qemu-devel@nongnu.org; Thu, 16 Jul 2015 05:14:42 -0400 Received: by widic2 with SMTP id ic2so9722317wid.0 for ; Thu, 16 Jul 2015 02:14:41 -0700 (PDT) Sender: Paolo Bonzini References: <1436980403-25898-1-git-send-email-pbonzini@redhat.com> <20150716052920.GA15296@ad.nay.redhat.com> From: Paolo Bonzini Message-ID: <55A775FD.9060700@redhat.com> Date: Thu, 16 Jul 2015 11:14:37 +0200 MIME-Version: 1.0 In-Reply-To: <20150716052920.GA15296@ad.nay.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] AioContext: fix broken ctx->dispatching optimization List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, lersek@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, rjones@redhat.com On 16/07/2015 07:29, Fam Zheng wrote: >> This patch rewrites the ctx->dispatching optimization > > I lost track, but what was the justification of this optimization? qemu_bh_schedule's call to aio_notify were showing in the profile as 20% or so. Paolo > Anyway, awesome debugging and explanations!