From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36944) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFooY-0005Oi-Ax for qemu-devel@nongnu.org; Thu, 16 Jul 2015 15:27:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZFooU-0001jj-Ja for qemu-devel@nongnu.org; Thu, 16 Jul 2015 15:27:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58629) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFooU-0001jd-Dj for qemu-devel@nongnu.org; Thu, 16 Jul 2015 15:27:22 -0400 References: <20150713200936.GK1606@HEDWIG.INI.CMU.EDU> <20150714094346.GR29283@redhat.com> <20150716004322.GA15850@GLSMBP.INI.CMU.EDU> From: Eric Blake Message-ID: <55A80593.60309@redhat.com> Date: Thu, 16 Jul 2015 13:27:15 -0600 MIME-Version: 1.0 In-Reply-To: <20150716004322.GA15850@GLSMBP.INI.CMU.EDU> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kAQ5Ut8LWpxugaqIn0CHxdRV9wmFnj806" Subject: Re: [Qemu-devel] RFC: guest-side retrieval of fw_cfg file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gabriel L. Somlo" , "Richard W.M. Jones" Cc: matt.fleming@intel.com, mdroth@linux.vnet.ibm.com, jordan.l.justen@intel.com, "Gabriel L. Somlo" , qemu-devel@nongnu.org, gleb@cloudius-systems.com, kraxel@redhat.com, pbonzini@redhat.com, Laszlo Ersek This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kAQ5Ut8LWpxugaqIn0CHxdRV9wmFnj806 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/15/2015 06:43 PM, Gabriel L. Somlo wrote: >=20 > OK, so I replaced my port i/o with mmio equivalents: >=20 > -#define FW_CFG_PORT_CTL 0x510 > +#define FW_CFG_PORT_CTL (void *)0x09020008 >=20 > -#define FW_CFG_PORT_DATA 0x511 > +#define FW_CFG_PORT_DATA (void *)0x09020000 Under-parenthesized; you'll want: #define FW_CFG_PORT_DATA ((void *)0x09020000) to be useful in all possible locations where an identifier can appear in an expression. >=20 > - outw(select, FW_CFG_PORT_CTL); > + writew(select, FW_CFG_PORT_CTL); >=20 > - inb(FW_CFG_PORT_DATA); > + readb(FW_CFG_PORT_DATA); >=20 > - insb(FW_CFG_PORT_DATA, buf, count); > + readsb(FW_CFG_PORT_DATA, buf, count); But as it doesn't affect your usage here... >=20 > I'm probably missing something that'll turn out to be really obvious > in retrospect... :) I probably didn't spot the really obvious problem. So much for my drive-by noise :) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --kAQ5Ut8LWpxugaqIn0CHxdRV9wmFnj806 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVqAWTAAoJEKeha0olJ0Nq5ncH/ifitaPSLvY1Atx9WCtHj0v1 6V+qvpQTpkLlxbqzOaMXLaDbi6Outbz/BUR5mGYQ/1mBt57AE9rG2BLmFUn0cF+v Bwc3Si8jgWLl1aeBRN0+M7iHsa3rRa68WeIz2fBoq3fSG19nNoDDVS2jBftZy4H1 6nHAQzix7QKi2UvVeMrF6TfzTXpB++yWZIAyj70I5JEl8RU+JCDj7EAxpKME8X1p rfHB0GXZBOsLl7MAVOUYBzIkJ92q5Kp7j5NzHUGnkaLz6eAH3lrwvJ06B6Mqufxe DPa3lcZ8XHuPDmPsVtVYwG5sYPQeAps82bIm25GLLPA2gXA9+65STWWgLHLxuz0= =3f46 -----END PGP SIGNATURE----- --kAQ5Ut8LWpxugaqIn0CHxdRV9wmFnj806--