From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54053)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZFyuO-00029F-Et
	for qemu-devel@nongnu.org; Fri, 17 Jul 2015 02:14:09 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZFyuL-0003C7-7A
	for qemu-devel@nongnu.org; Fri, 17 Jul 2015 02:14:08 -0400
Received: from mail-wg0-x234.google.com ([2a00:1450:400c:c00::234]:36566)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1ZFyuK-0003Br-U1
	for qemu-devel@nongnu.org; Fri, 17 Jul 2015 02:14:05 -0400
Received: by wgxm20 with SMTP id m20so74160505wgx.3
	for <qemu-devel@nongnu.org>; Thu, 16 Jul 2015 23:14:04 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
References: <1436958199-5181-1-git-send-email-aurelien@aurel32.net>
	<1436958199-5181-2-git-send-email-aurelien@aurel32.net>
From: Richard Henderson <rth@twiddle.net>
Message-ID: <55A89D29.1010805@twiddle.net>
Date: Fri, 17 Jul 2015 07:14:01 +0100
MIME-Version: 1.0
In-Reply-To: <1436958199-5181-2-git-send-email-aurelien@aurel32.net>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH RFC 1/9] tcg: rename trunc_shr_i32 into
	trunc_shr_i64_i32
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>

On 07/15/2015 12:03 PM, Aurelien Jarno wrote:
> The op is sometimes named trunc_shr_i32 and sometimes trunc_shr_i64_i32,
> and the name in the README doesn't match the name offered to the
> frontends.
>
> Always use the long name to make it clear it is a size changing op.
>
> Cc: Paolo Bonzini<pbonzini@redhat.com>
> Cc: Richard Henderson<rth@twiddle.net>
> Signed-off-by: Aurelien Jarno<aurelien@aurel32.net>
> ---
>   tcg/README               | 2 +-
>   tcg/aarch64/tcg-target.h | 2 +-
>   tcg/i386/tcg-target.h    | 2 +-
>   tcg/ia64/tcg-target.h    | 2 +-
>   tcg/optimize.c           | 6 +++---
>   tcg/ppc/tcg-target.h     | 2 +-
>   tcg/s390/tcg-target.h    | 2 +-
>   tcg/sparc/tcg-target.c   | 4 ++--
>   tcg/sparc/tcg-target.h   | 2 +-
>   tcg/tcg-op.c             | 4 ++--
>   tcg/tcg-opc.h            | 4 ++--
>   tcg/tcg.h                | 2 +-
>   tcg/tci/tcg-target.h     | 2 +-
>   13 files changed, 18 insertions(+), 18 deletions(-)

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~