From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39970)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1ZG02J-00067m-N9
	for qemu-devel@nongnu.org; Fri, 17 Jul 2015 03:26:24 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1ZG02G-0007rl-FG
	for qemu-devel@nongnu.org; Fri, 17 Jul 2015 03:26:23 -0400
Received: from mx1.redhat.com ([209.132.183.28]:57065)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marcel@redhat.com>) id 1ZG02F-0007qD-Qa
	for qemu-devel@nongnu.org; Fri, 17 Jul 2015 03:26:20 -0400
Message-ID: <55A8AE18.5070704@redhat.com>
Date: Fri, 17 Jul 2015 10:26:16 +0300
From: Marcel Apfelbaum <marcel@redhat.com>
MIME-Version: 1.0
References: <20150716045509.GC4827@in.ibm.com>	<20150716103007.GE4827@in.ibm.com>
	<20150716142421.4478d67e@nial.brq.redhat.com>
In-Reply-To: <20150716142421.4478d67e@nial.brq.redhat.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] memory hotplug fails with mem-merge option
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>, Bharata B Rao <bharata@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, David Gibson <david@gibson.dropbear.id.au>

On 07/16/2015 03:24 PM, Igor Mammedov wrote:
> On Thu, 16 Jul 2015 16:00:07 +0530
> Bharata B Rao <bharata@linux.vnet.ibm.com> wrote:
>
>> On Thu, Jul 16, 2015 at 10:25:09AM +0530, Bharata B Rao wrote:
>>> Hi,
>>>
>>> When I use -machine pc,mem-merge=off|on -m 1G,slots=4,maxmem=2G, adding
>>> memory-backend-ram object fails like below. Same failure is seen with
>>> -machine pseries,mem-merge=on|off.
>>>
>>> (qemu) object_add memory-backend-ram,id=ram0,size=1G
>>>
>>> qemu-system-x86_64: util/qemu-option.c:388: qemu_opt_get_bool_helper: Assertion `opt->desc && opt->desc->type == QEMU_OPT_BOOL' failed.
>>
>> Same failure seen with -machine pseries,mem-merge=off when used together with
>> -object memory-backend-file on QEMU commandline in which case boot time
>> failure is observed.
>>
>> Regards,
>> Bharata.
>
> looks like related to
>
> 0a7cf217 util/qemu-config: fix regression of qmp_query_command_line_options
> and
> 49d2e64 machine: remove qemu_machine_opts global list
>
> CCing Marcel in hope he knows how to fix it right away.
Hi,

Can you please check that Eduardo's patch fixes this?
     [PATCH] hostmem: Fix qemu_opt_get_bool() crash in host_memory_backend_init()
     https://www.mail-archive.com/qemu-devel@nongnu.org/msg310915.html

Thanks,
Marcel

>