From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46283) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZGR9T-0003Ek-Hk for qemu-devel@nongnu.org; Sat, 18 Jul 2015 08:23:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZGR9O-0002Xe-Iz for qemu-devel@nongnu.org; Sat, 18 Jul 2015 08:23:35 -0400 Received: from mail-wi0-x233.google.com ([2a00:1450:400c:c05::233]:38044) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZGR9O-0002XS-Bb for qemu-devel@nongnu.org; Sat, 18 Jul 2015 08:23:30 -0400 Received: by wicmv11 with SMTP id mv11so61419073wic.1 for ; Sat, 18 Jul 2015 05:23:29 -0700 (PDT) Sender: Paolo Bonzini References: <86f43fc5800c8f18c03d0ee8f26de440bac4f9fb.1437212383.git.crosthwaite.peter@gmail.com> From: Paolo Bonzini Message-ID: <55AA452C.7050700@redhat.com> Date: Sat, 18 Jul 2015 14:23:08 +0200 MIME-Version: 1.0 In-Reply-To: <86f43fc5800c8f18c03d0ee8f26de440bac4f9fb.1437212383.git.crosthwaite.peter@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 20/35] Makefile.target: Introduce arch-obj List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, rth@twiddle.net, edgar.iglesias@gmail.com, afaerber@suse.de, Peter Crosthwaite On 18/07/2015 11:40, Peter Crosthwaite wrote: > -) > > diff --git a/Makefile.target b/Makefile.target > index 6186f03..31eda57 100644 > --- a/Makefile.target > +++ b/Makefile.target > @@ -13,6 +13,12 @@ QEMU_CFLAGS += -I../linux-headers > endif > QEMU_CFLAGS += -I.. -I$(SRC_PATH)/target-$(TARGET_BASE_ARCH) -DNEED_CPU_H > > +ifeq ($(TARGET_BASE_ARCH), multi) > +ARCH_DIRS=$(MULTI_BASE_TARGETS) > +else > +ARCH_DIRS=$(TARGET_BASE_ARCH) > +endif Perhaps ARCH_DIRS can be defined directly by configure in config-target.mak? It's the only place where MULTI_BASE_TARGETS is used. Paolo > +