From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZGUYD-00057J-C2 for qemu-devel@nongnu.org; Sat, 18 Jul 2015 12:01:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZGUY8-0003MN-DE for qemu-devel@nongnu.org; Sat, 18 Jul 2015 12:01:21 -0400 Received: from mail-wi0-x22b.google.com ([2a00:1450:400c:c05::22b]:33921) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZGUY8-0003Li-6c for qemu-devel@nongnu.org; Sat, 18 Jul 2015 12:01:16 -0400 Received: by wibud3 with SMTP id ud3so58805497wib.1 for ; Sat, 18 Jul 2015 09:01:15 -0700 (PDT) Sender: Paolo Bonzini References: <55AA4388.9070008@redhat.com> <55AA4889.9050000@redhat.com> From: Paolo Bonzini Message-ID: <55AA7846.6050109@redhat.com> Date: Sat, 18 Jul 2015 18:01:10 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 15/35] include/exec: Split target_long def to new header List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: Peter Crosthwaite , "qemu-devel@nongnu.org Developers" On 18/07/2015 17:37, Peter Crosthwaite wrote: > > > Would it be possible, or make sense, to do > > > > > > #define target_long arm_target_long > > > #define target_ulong arm_target_ulong > > > > > > instead? This makes prototypes nicer when printed in the debugger with > > > ptype. Where could this be done? > > > > Hmm, ISTR that this was more or less what v2 was like, so I guess you > > made the change for a reason. :) So ignore this. > > I made this change to reduce the cpu.h boiler-plate change pattern and > it makes the undeffery system consistent with other defs. We could go > back to the other way to get this debugability if you think it is > preferrable? Code simplicity vs utility ultimately. Unless someone else complains, this version is okay with me. Paolo