From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51334) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZH539-0005LG-Ey for qemu-devel@nongnu.org; Mon, 20 Jul 2015 02:59:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZH536-0006CZ-AO for qemu-devel@nongnu.org; Mon, 20 Jul 2015 02:59:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51619) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZH536-0006CN-5S for qemu-devel@nongnu.org; Mon, 20 Jul 2015 02:59:40 -0400 Message-ID: <55AC9C56.7080605@redhat.com> Date: Mon, 20 Jul 2015 08:59:34 +0200 From: Thomas Huth MIME-Version: 1.0 References: <1437245366-20156-1-git-send-email-abezzubikov@ispras.ru> In-Reply-To: <1437245366-20156-1-git-send-email-abezzubikov@ispras.ru> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC] ATAPI-SCSI bridge GSoC project List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Bezzubikov , qemu-devel@nongnu.org On 18/07/15 20:49, Alexander Bezzubikov wrote: > atapi: ATAPI-SCSI bridge device created > private SCSI bus added to bridge > ATAPI inquiry command can use a bridge Hi! Not everybody is familiar with your GSoC project, so it would be great if you could be a little bit more verbose in your patch description. Unfortunately, your patch also has some style issues, please make sure to read http://qemu-project.org/Contribute/SubmitAPatch first. Especially: - Your patch lacks a Signed-off-by line - scripts/checkpatch.pl reports quite a bunch of errors - Make sure to CC the right maintainers Hope that helps, Thomas