From: Eric Blake <eblake@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Jason Wang <jasowang@redhat.com>,
clg@fr.ibm.com, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PULL 3/6] virtio-net: unbreak any layout
Date: Mon, 20 Jul 2015 08:26:41 -0600 [thread overview]
Message-ID: <55AD0521.1070601@redhat.com> (raw)
In-Reply-To: <1437394279-24416-4-git-send-email-mst@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 970 bytes --]
On 07/20/2015 06:12 AM, Michael S. Tsirkin wrote:
> From: Jason Wang <jasowang@redhat.com>
>
> Commit 032a74a1c0fcdd5fd1c69e56126b4c857ee36611
> ("virtio-net: byteswap virtio-net header") breaks any layout by
> requiring out_sg[0].iov_len >= n->guest_hdr_len. Fixing this by
> copying header to temporary buffer if swap is needed, and then use
> this buffer as part of out_sg.
>
> Fixes 032a74a1c0fcdd5fd1c69e56126b4c857ee36611
> ("virtio-net: byteswap virtio-net header")
> Cc: qemu-stable@nongnu.org
> Cc: clg@fr.ibm.com
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> Reviewed-by: Eric Blake <eblake@redhat.com>
I think my R-b was intended for 2/6, not this one. But if this has
already been pulled, it's not a show-stopper.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-07-20 14:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 12:12 [Qemu-devel] [PULL 0/6] virtio, vhost, pc fixes for 2.4 Michael S. Tsirkin
2015-07-20 12:12 ` [Qemu-devel] [PULL 1/6] ich9: fix skipped vmstate_memhp_state subsection Michael S. Tsirkin
2015-07-20 12:12 ` [Qemu-devel] [PULL 2/6] Revert "vhost-user: add multi queue support" Michael S. Tsirkin
2015-07-20 12:12 ` [Qemu-devel] [PULL 3/6] virtio-net: unbreak any layout Michael S. Tsirkin
2015-07-20 14:26 ` Eric Blake [this message]
2015-07-20 12:12 ` [Qemu-devel] [PULL 4/6] pci_add_capability: remove duplicate comments Michael S. Tsirkin
2015-07-20 12:12 ` [Qemu-devel] [PULL 5/6] virtio-net: Flush incoming queues when DRIVER_OK is being set Michael S. Tsirkin
2015-07-20 12:12 ` [Qemu-devel] [PULL 6/6] virtio-net: remove virtio queues if the guest doesn't support multiqueue Michael S. Tsirkin
2015-07-20 15:01 ` [Qemu-devel] [PULL 0/6] virtio, vhost, pc fixes for 2.4 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AD0521.1070601@redhat.com \
--to=eblake@redhat.com \
--cc=clg@fr.ibm.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).