From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50934) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHC1m-0002ka-Jo for qemu-devel@nongnu.org; Mon, 20 Jul 2015 10:26:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZHC1j-00074O-Di for qemu-devel@nongnu.org; Mon, 20 Jul 2015 10:26:46 -0400 References: <1437394279-24416-1-git-send-email-mst@redhat.com> <1437394279-24416-4-git-send-email-mst@redhat.com> From: Eric Blake Message-ID: <55AD0521.1070601@redhat.com> Date: Mon, 20 Jul 2015 08:26:41 -0600 MIME-Version: 1.0 In-Reply-To: <1437394279-24416-4-git-send-email-mst@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WW6Nb4Ot6S3rPfrNAIbkKks1W4tTGHa7A" Subject: Re: [Qemu-devel] [PULL 3/6] virtio-net: unbreak any layout List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , qemu-devel@nongnu.org Cc: Peter Maydell , Jason Wang , clg@fr.ibm.com, qemu-stable@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WW6Nb4Ot6S3rPfrNAIbkKks1W4tTGHa7A Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/20/2015 06:12 AM, Michael S. Tsirkin wrote: > From: Jason Wang >=20 > Commit 032a74a1c0fcdd5fd1c69e56126b4c857ee36611 > ("virtio-net: byteswap virtio-net header") breaks any layout by > requiring out_sg[0].iov_len >=3D n->guest_hdr_len. Fixing this by > copying header to temporary buffer if swap is needed, and then use > this buffer as part of out_sg. >=20 > Fixes 032a74a1c0fcdd5fd1c69e56126b4c857ee36611 > ("virtio-net: byteswap virtio-net header") > Cc: qemu-stable@nongnu.org > Cc: clg@fr.ibm.com > Signed-off-by: Jason Wang > Reviewed-by: Michael S. Tsirkin > Signed-off-by: Michael S. Tsirkin > Reviewed-by: Eric Blake I think my R-b was intended for 2/6, not this one. But if this has already been pulled, it's not a show-stopper. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --WW6Nb4Ot6S3rPfrNAIbkKks1W4tTGHa7A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVrQUhAAoJEKeha0olJ0NqzowIAKYx7uPIM15NUlBBACPHx1N1 a7rjHQHLiCPkBRZVHEeT8Ydiwdoxo2FcEIzPtg1ZUzW9LVXhHGYPiD+wbUnZYaAo fCZy0L5pwHeBvuq3R+/1MDGTLhwF7fELsxo9JP//V0cZ0K5y0EVfeyarxCm8zhw/ Qv/LTIw1hEBcllDLfk5jOXfBj/NdcrfdBhoibg/5V0hjI0WV3CbiqlYnQGxbB9Cc raA2jxA8d2er1WukHMr2LucM466lHRC8JHfvFjnpIaLxTj0ac1l1C3cHlc4+k5pa EB5lHuy4gzTRD/OOu9kb4meEdDP5/WVxDD0bIotnQPxdrIeRqD6gVHcPptRSAlw= =YN/A -----END PGP SIGNATURE----- --WW6Nb4Ot6S3rPfrNAIbkKks1W4tTGHa7A--