From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHCeQ-0002TY-DH for qemu-devel@nongnu.org; Mon, 20 Jul 2015 11:06:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZHCeM-0007EB-6t for qemu-devel@nongnu.org; Mon, 20 Jul 2015 11:06:42 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36942) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHCeL-0007Dw-W5 for qemu-devel@nongnu.org; Mon, 20 Jul 2015 11:06:38 -0400 References: <1436244020-27822-1-git-send-email-mdroth@linux.vnet.ibm.com> <1436244020-27822-10-git-send-email-mdroth@linux.vnet.ibm.com> From: Eric Blake Message-ID: <55AD0E7C.6000301@redhat.com> Date: Mon, 20 Jul 2015 09:06:36 -0600 MIME-Version: 1.0 In-Reply-To: <1436244020-27822-10-git-send-email-mdroth@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2srq8T5agc4JWh5UU1mNGt47kHn9Cos9w" Subject: Re: [Qemu-devel] [PATCH 09/10] qga: added bus type and disk location path List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth , qemu-devel@nongnu.org Cc: "Denis V. Lunev" , Olga Krishtal , peter.maydell@linaro.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2srq8T5agc4JWh5UU1mNGt47kHn9Cos9w Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/06/2015 10:40 PM, Michael Roth wrote: > From: Olga Krishtal >=20 > According to Microsoft disk location path can be obtained via > IOCTL_SCSI_GET_ADDRESS. Unfortunately this ioctl can not be used for al= l > devices. There are certain bus types which could be obtained with this > API. Please, refer to the following link for more details > https://technet.microsoft.com/en-us/library/ee851589(v=3Dws.10).aspx >=20 > Bus type could be obtained using IOCTL_STORAGE_QUERY_PROPERTY. Enum > STORAGE_BUS_TYPE describes all buses supported by OS. >=20 > Windows defines more bus types than Linux. Thus some values have been a= dded > to GuestDiskBusType. >=20 > Signed-off-by: Olga Krishtal > Signed-off-by: Denis V. Lunev > CC: Eric Blake > CC: Michael Roth > * fixed warning in CreateFile due to use of NULL instead of 0 > Signed-off-by: Michael Roth > --- > +++ b/qga/qapi-schema.json > @@ -703,12 +703,24 @@ > # @uml: UML disks > # @sata: SATA disks > # @sd: SD cards > +# @unknown: Unknown bus type > +# @ieee1394: Win IEEE 1394 bus type > +# @ssa: Win SSA bus type > +# @fibre: Win fiber channel bus type > +# @raid: Win RAID bus type > +# @iscsi: Win iScsi bus type > +# @sas: Win serial-attaches SCSI bus type > +# @mmc: Win multimedia card (MMC) bus type > +# @virtual: Win virtual bus type > +# @file-backed virtual: Win file-backed bus type > # > # Since: 2.2 It would be nice to have a followup patch (since it is doc-only, it could still make 2.4) that mentions that all these new enum members were added in 2.4. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --2srq8T5agc4JWh5UU1mNGt47kHn9Cos9w Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVrQ58AAoJEKeha0olJ0Nq4t8IAKXpOH6d3STq1ympwoWxa/Bn O6+Z8MkVbivx2Y+lEC2y/Dm/YOPAMnFpBjlO+bjAud9eTGvEPp21+jGXoy7CuOGg R01FO5HsvZESFVDiKCS/y3F7OAltwnQE8I9PRfjcx+PoE4DcyJHU+pQAg5WxC++t Y5FrZLYcXGLgOG7fZeWnQbfzA8UwvwoMmujl02tdedqcAL624eMLMWDIGgiXaA/S UnzX9xM2UovlV3FMsPB9mlr63zuHGl/c29w7B3LaCbydiS9CQrUOvDUgj2fEJOpw +d0+GLvlkES1D5wv/yp2CMo24UndFiEHfHMsyFgEp1VLiNGkYeuVohjuZ0g+5CE= =FAJG -----END PGP SIGNATURE----- --2srq8T5agc4JWh5UU1mNGt47kHn9Cos9w--