From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35973) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHCiS-00042p-D6 for qemu-devel@nongnu.org; Mon, 20 Jul 2015 11:10:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZHCiR-0000uu-Hg for qemu-devel@nongnu.org; Mon, 20 Jul 2015 11:10:52 -0400 References: <1435202570-12360-1-git-send-email-famz@redhat.com> <1435202570-12360-2-git-send-email-famz@redhat.com> From: Max Reitz Message-ID: <55AD0F70.4070706@redhat.com> Date: Mon, 20 Jul 2015 17:10:40 +0200 MIME-Version: 1.0 In-Reply-To: <1435202570-12360-2-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/6] block: Add blocker on mirror target List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org, Jeff Cody , Markus Armbruster , Stefan Hajnoczi , pbonzini@redhat.com On 25.06.2015 05:22, Fam Zheng wrote: > In block/backup.c, we already check and add blocker on the target bs, > which is necessary so that it won't be intervened with other operations. > > In block/mirror.c we should also protect the mirror target bs, because it > could have a node-name (drive-mirror ... node-name=XXX), and on top of > that it's safe to add blockdev-mirror. > > Signed-off-by: Fam Zheng > --- > block/mirror.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Max Reitz