From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41386) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHD21-0003O3-Uc for qemu-devel@nongnu.org; Mon, 20 Jul 2015 11:31:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZHD21-0000t4-4D for qemu-devel@nongnu.org; Mon, 20 Jul 2015 11:31:05 -0400 References: <1435202570-12360-1-git-send-email-famz@redhat.com> <1435202570-12360-4-git-send-email-famz@redhat.com> From: Max Reitz Message-ID: <55AD1422.1070505@redhat.com> Date: Mon, 20 Jul 2015 17:30:42 +0200 MIME-Version: 1.0 In-Reply-To: <1435202570-12360-4-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 3/6] block: Extract blockdev part of qmp_drive_mirror List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org, Jeff Cody , Markus Armbruster , Stefan Hajnoczi , pbonzini@redhat.com On 25.06.2015 05:22, Fam Zheng wrote: > This is the part that will be reused by blockdev-mirror. > > Signed-off-by: Fam Zheng > --- > blockdev.c | 155 ++++++++++++++++++++++++++++++++++++------------------------- > 1 file changed, 92 insertions(+), 63 deletions(-) As you probably know (since you introduced it), this needs fixup due to 0fc9f8ea28. (And the changes are not trivial, unfortunately, so I had to give up fixing it locally.) Generally, the set of changes looks good to me, though. Max