From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHDYB-00046V-Fh for qemu-devel@nongnu.org; Mon, 20 Jul 2015 12:04:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZHDY5-0007Cg-U1 for qemu-devel@nongnu.org; Mon, 20 Jul 2015 12:04:19 -0400 References: <1437338062-26577-1-git-send-email-peter.maydell@linaro.org> From: Eric Blake Message-ID: <55AD1BF7.4020305@redhat.com> Date: Mon, 20 Jul 2015 10:04:07 -0600 MIME-Version: 1.0 In-Reply-To: <1437338062-26577-1-git-send-email-peter.maydell@linaro.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OgCmAS3wIlvLfLPuVbmIiJT4TRccG9qNR" Subject: Re: [Qemu-devel] [PATCH] qemu-common.h: Document cutils.c string functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, patches@linaro.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OgCmAS3wIlvLfLPuVbmIiJT4TRccG9qNR Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/19/2015 02:34 PM, Peter Maydell wrote: > Add documentation comments for various utility string functions > which we have implemented in util/cutils.c: > pstrcpy() > strpadcpy() > pstrcat() > strstart() > stristart() > qemu_strnlen() > qemu_strsep() >=20 > Signed-off-by: Peter Maydell > --- > We recommend pstrcpy() &c in HACKING but that's not very helpful > if we don't actually document their behaviour... Don't know if we care about US vs. UK spelling in doc comments, so I'll ignore it, and give: Reviewed-by: Eric Blake >=20 > include/qemu-common.h | 114 ++++++++++++++++++++++++++++++++++++++++++= +++++++- > 1 file changed, 113 insertions(+), 1 deletion(-) >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --OgCmAS3wIlvLfLPuVbmIiJT4TRccG9qNR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVrRv3AAoJEKeha0olJ0Nq9xIIAJTT9iU75uLuRZcx/cHP9QgJ BMhDKFk/9WNufBjtmf1GRuT4lKQ2xHXZzCzO+dH0W59eF0vndR+9d/Flw6cLn1XJ +YTKsx/q3D27qEX5IizqPbmXdbw66R120lGHTXxRrlHQon70x2Tvl7M5d7M7dumO sn3pnLrHKpyYH8FL7XtV5eoJsJzPhTFfiWXb58aI5NHTlHLmBfLWVANKDFCFfLbp bjoXLfFE6i9ijo3Jua1sLnDTAsfh70P9Rc//Cgc5dvEznfWfYMzwQ0Ihf+VYmGFT IaS565DLZAeSpPFHywUyxYk7UBielQXPzKS/sXTdTZZD+mu5Ss0OBpA59YHdMIQ= =jAs3 -----END PGP SIGNATURE----- --OgCmAS3wIlvLfLPuVbmIiJT4TRccG9qNR--