From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34528)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1ZHDrS-0004RT-Hy
	for qemu-devel@nongnu.org; Mon, 20 Jul 2015 12:24:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1ZHDrN-0000rC-U6
	for qemu-devel@nongnu.org; Mon, 20 Jul 2015 12:24:14 -0400
Message-ID: <55AD20A7.6030908@redhat.com>
Date: Mon, 20 Jul 2015 12:24:07 -0400
From: John Snow <jsnow@redhat.com>
MIME-Version: 1.0
References: <1437231284-17455-1-git-send-email-sw@weilnetz.de>
In-Reply-To: <1437231284-17455-1-git-send-email-sw@weilnetz.de>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH for-2.4] tests: Fix broken targets
	check-report-qtest-*
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>, QEMU Trivial <qemu-trivial@nongnu.org>, Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developer <qemu-devel@nongnu.org>



On 07/18/2015 10:54 AM, Stefan Weil wrote:
> They need QTEST_QEMU_IMG. Without it, the tests raise an assertion:
>=20
> $ make -C bin check-report-qtest-i386.xml
> make: Entering directory 'bin'
> GTESTER check-report-qtest-i386.xml
> blkdebug: Suspended request 'A'
> blkdebug: Resuming request 'A'
> ahci-test: tests/libqos/libqos.c:162:
>  mkimg: Assertion `qemu_img_path' failed.
> main-loop: WARNING: I/O thread spun for 1000 iterations
>=20
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  tests/Makefile | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/tests/Makefile b/tests/Makefile
> index 2c4b8dc..8d26736 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -478,6 +478,7 @@ $(patsubst %, check-%, $(check-unit-y)): check-%: %
> =20
>  $(patsubst %, check-report-qtest-%.xml, $(QTEST_TARGETS)): check-repor=
t-qtest-%.xml: $(check-qtest-y)
>  	$(call quiet-command,QTEST_QEMU_BINARY=3D$*-softmmu/qemu-system-$* \
> +		QTEST_QEMU_IMG=3Dqemu-img$(EXESUF) \
>  	  gtester -q $(GTESTER_OPTIONS) -o $@ -m=3D$(SPEED) $(check-qtest-$*-=
y),"GTESTER $@")
> =20
>  check-report-unit.xml: $(check-unit-y)
>=20

My apologies -- missed a spot when I added this.
I'll stage this one in my IDE branch if nobody feels it belongs in a
different tree.

Reviewed-by: John Snow <jsnow@redhat.com>