* [Qemu-devel] [PATCH for-2.4] tests: Fix broken targets check-report-qtest-*
@ 2015-07-18 14:54 Stefan Weil
2015-07-20 16:24 ` John Snow
2015-07-20 16:25 ` John Snow
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Weil @ 2015-07-18 14:54 UTC (permalink / raw)
To: QEMU Trivial, Peter Maydell; +Cc: Stefan Weil, QEMU Developer
They need QTEST_QEMU_IMG. Without it, the tests raise an assertion:
$ make -C bin check-report-qtest-i386.xml
make: Entering directory 'bin'
GTESTER check-report-qtest-i386.xml
blkdebug: Suspended request 'A'
blkdebug: Resuming request 'A'
ahci-test: tests/libqos/libqos.c:162:
mkimg: Assertion `qemu_img_path' failed.
main-loop: WARNING: I/O thread spun for 1000 iterations
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
tests/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/Makefile b/tests/Makefile
index 2c4b8dc..8d26736 100644
--- a/tests/Makefile
+++ b/tests/Makefile
@@ -478,6 +478,7 @@ $(patsubst %, check-%, $(check-unit-y)): check-%: %
$(patsubst %, check-report-qtest-%.xml, $(QTEST_TARGETS)): check-report-qtest-%.xml: $(check-qtest-y)
$(call quiet-command,QTEST_QEMU_BINARY=$*-softmmu/qemu-system-$* \
+ QTEST_QEMU_IMG=qemu-img$(EXESUF) \
gtester -q $(GTESTER_OPTIONS) -o $@ -m=$(SPEED) $(check-qtest-$*-y),"GTESTER $@")
check-report-unit.xml: $(check-unit-y)
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH for-2.4] tests: Fix broken targets check-report-qtest-*
2015-07-18 14:54 [Qemu-devel] [PATCH for-2.4] tests: Fix broken targets check-report-qtest-* Stefan Weil
@ 2015-07-20 16:24 ` John Snow
2015-07-20 16:25 ` John Snow
1 sibling, 0 replies; 3+ messages in thread
From: John Snow @ 2015-07-20 16:24 UTC (permalink / raw)
To: Stefan Weil, QEMU Trivial, Peter Maydell; +Cc: QEMU Developer
On 07/18/2015 10:54 AM, Stefan Weil wrote:
> They need QTEST_QEMU_IMG. Without it, the tests raise an assertion:
>
> $ make -C bin check-report-qtest-i386.xml
> make: Entering directory 'bin'
> GTESTER check-report-qtest-i386.xml
> blkdebug: Suspended request 'A'
> blkdebug: Resuming request 'A'
> ahci-test: tests/libqos/libqos.c:162:
> mkimg: Assertion `qemu_img_path' failed.
> main-loop: WARNING: I/O thread spun for 1000 iterations
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> tests/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/Makefile b/tests/Makefile
> index 2c4b8dc..8d26736 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -478,6 +478,7 @@ $(patsubst %, check-%, $(check-unit-y)): check-%: %
>
> $(patsubst %, check-report-qtest-%.xml, $(QTEST_TARGETS)): check-report-qtest-%.xml: $(check-qtest-y)
> $(call quiet-command,QTEST_QEMU_BINARY=$*-softmmu/qemu-system-$* \
> + QTEST_QEMU_IMG=qemu-img$(EXESUF) \
> gtester -q $(GTESTER_OPTIONS) -o $@ -m=$(SPEED) $(check-qtest-$*-y),"GTESTER $@")
>
> check-report-unit.xml: $(check-unit-y)
>
My apologies -- missed a spot when I added this.
I'll stage this one in my IDE branch if nobody feels it belongs in a
different tree.
Reviewed-by: John Snow <jsnow@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH for-2.4] tests: Fix broken targets check-report-qtest-*
2015-07-18 14:54 [Qemu-devel] [PATCH for-2.4] tests: Fix broken targets check-report-qtest-* Stefan Weil
2015-07-20 16:24 ` John Snow
@ 2015-07-20 16:25 ` John Snow
1 sibling, 0 replies; 3+ messages in thread
From: John Snow @ 2015-07-20 16:25 UTC (permalink / raw)
To: Stefan Weil, QEMU Trivial, Peter Maydell; +Cc: QEMU Developer
On 07/18/2015 10:54 AM, Stefan Weil wrote:
> They need QTEST_QEMU_IMG. Without it, the tests raise an assertion:
>
> $ make -C bin check-report-qtest-i386.xml
> make: Entering directory 'bin'
> GTESTER check-report-qtest-i386.xml
> blkdebug: Suspended request 'A'
> blkdebug: Resuming request 'A'
> ahci-test: tests/libqos/libqos.c:162:
> mkimg: Assertion `qemu_img_path' failed.
> main-loop: WARNING: I/O thread spun for 1000 iterations
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> tests/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/Makefile b/tests/Makefile
> index 2c4b8dc..8d26736 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -478,6 +478,7 @@ $(patsubst %, check-%, $(check-unit-y)): check-%: %
>
> $(patsubst %, check-report-qtest-%.xml, $(QTEST_TARGETS)): check-report-qtest-%.xml: $(check-qtest-y)
> $(call quiet-command,QTEST_QEMU_BINARY=$*-softmmu/qemu-system-$* \
> + QTEST_QEMU_IMG=qemu-img$(EXESUF) \
> gtester -q $(GTESTER_OPTIONS) -o $@ -m=$(SPEED) $(check-qtest-$*-y),"GTESTER $@")
>
> check-report-unit.xml: $(check-unit-y)
>
Tentatively:
Thanks, applied to my IDE tree:
https://github.com/jnsnow/qemu/commits/ide
https://github.com/jnsnow/qemu.git
--js
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-20 16:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-18 14:54 [Qemu-devel] [PATCH for-2.4] tests: Fix broken targets check-report-qtest-* Stefan Weil
2015-07-20 16:24 ` John Snow
2015-07-20 16:25 ` John Snow
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).