From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40012) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHECU-0004QG-64 for qemu-devel@nongnu.org; Mon, 20 Jul 2015 12:45:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZHECR-0002XJ-0I for qemu-devel@nongnu.org; Mon, 20 Jul 2015 12:45:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57426) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHECQ-0002XF-RM for qemu-devel@nongnu.org; Mon, 20 Jul 2015 12:45:54 -0400 References: <1435782155-31412-1-git-send-email-armbru@redhat.com> <1435782155-31412-3-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <55AD25BB.1020103@redhat.com> Date: Mon, 20 Jul 2015 10:45:47 -0600 MIME-Version: 1.0 In-Reply-To: <1435782155-31412-3-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="WqS9QPs4ua2gmmSAm0dgab3wHWb8NB2iN" Subject: Re: [Qemu-devel] [PATCH RFC v2 02/47] qapi: Clean up cgen() and mcgen() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, berto@igalia.com, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WqS9QPs4ua2gmmSAm0dgab3wHWb8NB2iN Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/01/2015 02:21 PM, Markus Armbruster wrote: > Commit 05dfb26 added eatspace stripping to mcgen(). Move it to > cgen(), just in case somebody gets tempted to use cgen() directly > instead of via mcgen(). >=20 > cgen() indents blank lines. No such lines get generated right now, > but fix it anyway. >=20 > We use triple-quoted strings for program text, like this: >=20 > ''' > Program text > any number of lines > ''' >=20 > Keeps the program text relatively readable, but puts an extra newline > at either end. mcgen() "fixes" that by dropping the first and last > line outright. Drop only the newlines. >=20 > This unmasks a bug in qapi-commands.py: four quotes instead of three. > Fix it up. >=20 > Output doesn't change Confirmed. >=20 > Signed-off-by: Markus Armbruster > --- > scripts/qapi-commands.py | 2 +- > scripts/qapi.py | 19 ++++++++++++------- > 2 files changed, 13 insertions(+), 8 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --WqS9QPs4ua2gmmSAm0dgab3wHWb8NB2iN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVrSW7AAoJEKeha0olJ0Nq8FEH/1zDT/U2cH++RDdounco3nfi hEEhDAAdzWFuerwcu8kEdIb43OTJhhOnITrV+grCHEAy47RO2j3F26R3PlpAlxA1 KA7ea4KVCXaR6GB5vGektDcojY4ZTQICWiuJ7v4SEY+dUDR/QIILtTFUY7yrvNX3 0L8SN+zvRep7bRentgB9huROFui6XQqLnVFUKSwGZ3Uz6DfIXBSv5lIIZMi0xYfv MepSYsvJ1qz028otVmMFa9SyMYK+pNryJKp8nNsXcfBNq79fuqGhLJHy1az9nXIT ogUYjHkELGk8s0s11XGCjDv2DvIMgCrxntwHX+e4TNJ1fPl8lFcetrLhFe/muXI= =CYHH -----END PGP SIGNATURE----- --WqS9QPs4ua2gmmSAm0dgab3wHWb8NB2iN--