From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53484) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHF8r-0003nR-Ec for qemu-devel@nongnu.org; Mon, 20 Jul 2015 13:46:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZHF8m-0000WY-NA for qemu-devel@nongnu.org; Mon, 20 Jul 2015 13:46:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41435) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHF8m-0000WH-IL for qemu-devel@nongnu.org; Mon, 20 Jul 2015 13:46:12 -0400 References: <1435782155-31412-1-git-send-email-armbru@redhat.com> <1435782155-31412-5-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <55AD33DE.40707@redhat.com> Date: Mon, 20 Jul 2015 11:46:06 -0600 MIME-Version: 1.0 In-Reply-To: <1435782155-31412-5-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2x2rGGTcFsgHoc0ReAofiqaOsAsNTkSGh" Subject: Re: [Qemu-devel] [PATCH RFC v2 04/47] qapi-event: Clean up how name of enum QAPIEvent is made List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, berto@igalia.com, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2x2rGGTcFsgHoc0ReAofiqaOsAsNTkSGh Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/01/2015 02:21 PM, Markus Armbruster wrote: > Use c_name() instead of ad hoc code. Doesn't upcase the -p prefix, > which is an improvement in my book. Unbreaks prefix containing '.', > but other funny characters remain broken. To be fixed next. >=20 > Signed-off-by: Markus Armbruster > --- > scripts/qapi-event.py | 2 +- > tests/test-qmp-event.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) No change to the generated qapi-event.[ch], so it looks like only the testsuite is affected. [In fact, as far as I can tell, only docs/qapi-code-gen.txt and tests/Makefile even take advantage of the '-p prefix' argument.] Fine by me. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --2x2rGGTcFsgHoc0ReAofiqaOsAsNTkSGh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVrTPeAAoJEKeha0olJ0NqfqYH/1/BVHF0d4cb2kH6O2luGs3C wkXzwqtv+WLwDtCML9ay/eYvDHTwdL3ZkrHslKYS9NEwcEkWoNRTwIRv7wWxT+c8 96TutMauLObtqb4B3AZFv1G1gMVwLN8o7khkgjDnjB8RIA9Uta7Bqp8owtIgyRFF tyST/mJQfIZeKWoOrfKo+0h+UJCUdZA6+xFfh/JaP30MhDlN7SlUwgYcqI2Y7fWs FGA9fnFllEVq6HjbK24Xnmpi/O77ELmfz56AvcWKaTfHYf8Kr3oUqkBfXkrekPIm RLcD/x3xJqXL4Dm8Cr/oAq9Tn0Kf2VYFaBko9J5Zzd70dk9Cf/8L4Oe2jt/x7Qg= =rJ5T -----END PGP SIGNATURE----- --2x2rGGTcFsgHoc0ReAofiqaOsAsNTkSGh--