From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47413)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1ZHGOM-0004r0-EW
	for qemu-devel@nongnu.org; Mon, 20 Jul 2015 15:06:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1ZHGOF-0000MD-Rc
	for qemu-devel@nongnu.org; Mon, 20 Jul 2015 15:06:19 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33898)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1ZHGOF-0000M1-M4
	for qemu-devel@nongnu.org; Mon, 20 Jul 2015 15:06:15 -0400
References: <55A158AF.8050907@redhat.com>
	<1436772752.26533.2.camel@redhat.com> <55A38FBD.4000203@redhat.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <55AD46A3.6060308@redhat.com>
Date: Mon, 20 Jul 2015 21:06:11 +0200
MIME-Version: 1.0
In-Reply-To: <55A38FBD.4000203@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] selecting VIRTIO_INPUT and VIRTIO_VGA
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Ard Biesheuvel <ard.biesheuvel@linaro.org>, qemu-devel <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>

Cc'ing Alex

On 07/13/15 12:15, Paolo Bonzini wrote:
> 
> 
> On 13/07/2015 09:32, Gerd Hoffmann wrote:
>>> and virtio-vga is only compiled on 64-bit Intel?
>>
>> There is virtio-gpu-pci ...
>>
>> Any specific reason why we need vga compatibility on !x86?
> 
> I was actually thinking about 32-bit x86. :)  I agree that !x86 is not
> necessary.

I disagree :)

(This is actually my more important followup to this thread; the other
message I just couldn't resist sending.)

Gerd recently contributed virtio-vga support to OvmfPkg/QemuVideoDxe:

https://github.com/tianocore/edk2/commit/94210dc9

That support depends on vga compat. All fine.

What's probably not obvious is that I had ported
PcAtChipsetPkg/PciHostBridgeDxe to ArmVirtPkg -- which drives Alex's
generic PCIe host bridge, exposed on qemu-system-(arm|aarch64) -M virt
-- and included OvmfPkg/QemuVideoDxe in the ArmVirtQemu.dsc build too.

That means you can currently stick a -device VGA into -M virt, and it
will work. Since OvmfPkg/QemuVideoDxe recognizes virtio-vga (see edk2
94210dc9 again), and the driver is included by ArmVirtQemu.dsc, I think
it would be probably useful to build the device model for arm/aarch64
targets too.

See also QEMU commit 332261de2b (together with its parent commits).

Thanks
Laszlo