From: Eric Blake <eblake@redhat.com>
To: "Qingshu Chen" <qingshu.chen714@gmail.com>, 夏虞斌 <xiayubin@gmail.com>
Cc: kwolf@redhat.com, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] ignore bdrv_flush operation when no qcow2 cache item is dirty
Date: Tue, 21 Jul 2015 06:46:29 -0600 [thread overview]
Message-ID: <55AE3F25.1090808@redhat.com> (raw)
In-Reply-To: <CANY5aGYomNo-xWvMiWe4=TxR524SPT0Cp0OecsMW9e5pFCKH=g@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1376 bytes --]
On 07/20/2015 07:51 PM, Qingshu Chen wrote:
> I've made a mistake on the series. Following is the new patch:
When re-sending a patch, it's better to start a new thread and include a
'v2' in the subject line.
>
>>From ef1079b422eef40a802ca13e249795005efa441d Mon Sep 17 00:00:00 2001
> From: Qingshu Chen <1150163259@qq.com>
> Date: Tue, 21 Jul 2015 09:46:08 +0800
> Subject: [PATCH] ignore bdrv_flush operation when no qcow2 cache item is
> dirty
> Signed-off-by: Qingshu Chen <qingshu.chen714@gmail.com>
>
> ---
> block/qcow2-cache.c | 16 ++++++++++++----
> block/qcow2.c | 2 ++
> 2 files changed, 14 insertions(+), 4 deletions(-)
> if (qcow2_need_accurate_refcounts(s)) {
> --
> 1.9.1
>
>
> 2015-07-20 23:03 GMT+08:00 Eric Blake <eblake@redhat.com>:
>>
>> [patches should always be sent to qemu-devel, even if qemu-block is also
>> in the to/cc list]
>>
>> On 07/08/2015 01:26 AM, Qingshu Chen wrote:
>>> qcow2_cache_flush() writes dirty cache to the disk and invokes
> bdrv_flush()
Replying to an existing mail, and worse, keeping the old patch in the
reply, makes it harder for maintainers to extract your patch.
For more hints on patch submissions, see
http://wiki.qemu.org/Contribute/SubmitAPatch
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
prev parent reply other threads:[~2015-07-21 12:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CANY5aGZc=-XsFasTB3-MiF-Vtof6ZLGsLYY0cSqir0MUC+X1Hg@mail.gmail.com>
2015-07-20 15:03 ` [Qemu-devel] [Qemu-block] [PATCH 1/2] ignore bdrv_flush operation when no qcow2 cache item is dirty Eric Blake
2015-07-21 1:51 ` Qingshu Chen
2015-07-21 12:46 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AE3F25.1090808@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qingshu.chen714@gmail.com \
--cc=xiayubin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).