From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35466) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHX0p-0003u8-SH for qemu-devel@nongnu.org; Tue, 21 Jul 2015 08:51:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZHX0k-0007wD-7f for qemu-devel@nongnu.org; Tue, 21 Jul 2015 08:51:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47658) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHX0k-0007vM-2E for qemu-devel@nongnu.org; Tue, 21 Jul 2015 08:51:06 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 941F33500F3 for ; Tue, 21 Jul 2015 12:51:05 +0000 (UTC) References: <1437468902-23230-1-git-send-email-berrange@redhat.com> From: Eric Blake Message-ID: <55AE4038.5000705@redhat.com> Date: Tue, 21 Jul 2015 06:51:04 -0600 MIME-Version: 1.0 In-Reply-To: <1437468902-23230-1-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sinTaNOA50MmlGcFuHxFXNEgRjes76hoB" Subject: Re: [Qemu-devel] [PATCH v2] crypto: extend unit tests to cover decryption too List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Kevin Wolf , Paolo Bonzini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --sinTaNOA50MmlGcFuHxFXNEgRjes76hoB Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/21/2015 02:55 AM, Daniel P. Berrange wrote: > The current unit test only verifies the encryption API, > resulting in us missing a recently introduced bug in the > decryption API from commit d3462e3. It was fortunately > later discovered & fixed by commit bd09594, thanks to the > QEMU I/O tests for qcow2 encryption, but we should really > detect this directly in the crypto unit tests. Also remove > an accidental debug message and simplify some asserts. >=20 > Signed-off-by: Daniel P. Berrange > --- > tests/test-crypto-cipher.c | 28 ++++++++++++++++++++-------- > 1 file changed, 20 insertions(+), 8 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --sinTaNOA50MmlGcFuHxFXNEgRjes76hoB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVrkA4AAoJEKeha0olJ0NqXIYIAIhe5+mmrfbrptjq/ww/gMEj veTj9m3Z3uZxs5FyYuhUCO6lQ8e3a+yQLh6FZ/LAJz3qHOLei/AQYc16faYRWlxa YrsjLS07GxzuDhBR1DgzgtUk9/NORZWXpnakbmfYAhddGrsttHU802JI9VYRin4m D1y2Eo8UwfHuOPXOBKSXgUQ3bsbxoCAcn6vrCXZNhaSyBsvHLXTntxl3tV9bvyFj h2KS8fVO7tgVOQkdTNORLmKaSgDpfhTLEp3CZlkPQuKDtIuOf1kN8int2tBiVeiR wASWjX5MNBsrN5D6zDLPZFBPEV7bbOvY9D/Us3Tg1xNACiihGzVQoCBa9s5iNTM= =dkxu -----END PGP SIGNATURE----- --sinTaNOA50MmlGcFuHxFXNEgRjes76hoB--