From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36714) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHX5J-00063r-FV for qemu-devel@nongnu.org; Tue, 21 Jul 2015 08:55:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZHX5E-00019p-Vi for qemu-devel@nongnu.org; Tue, 21 Jul 2015 08:55:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56982) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHX5E-00019h-Qc for qemu-devel@nongnu.org; Tue, 21 Jul 2015 08:55:44 -0400 References: <1437416961-26348-1-git-send-email-jsnow@redhat.com> <1437416961-26348-3-git-send-email-jsnow@redhat.com> From: Eric Blake Message-ID: <55AE414E.6070505@redhat.com> Date: Tue, 21 Jul 2015 06:55:42 -0600 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vv6CI3pSLg9iQPA1iQnlibuh7VcqxwLXW" Subject: Re: [Qemu-devel] [PULL 2/3] ahci: Force ICC bits in PxCMD to zero List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , John Snow Cc: Stefan Fritsch , QEMU Developers This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vv6CI3pSLg9iQPA1iQnlibuh7VcqxwLXW Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/21/2015 05:38 AM, Peter Maydell wrote: > On 20 July 2015 at 19:29, John Snow wrote: >> From: Stefan Fritsch >> >> The AHCI spec requires that the HBA sets the ICC bits to zero after th= e >> ICC change is done. Since we don't do any ICC change, force the bits t= o >> zero all the time. >> >> This fixes delays with some OSs (e.g. OpenBSD) waiting for the ICC bit= s >> to change to 0. >=20 > This change provokes a lot of clang sanitizer warnings: >=20 > /home/petmay01/linaro/qemu-for-merges/hw/ide/ahci.c:288:49: runtime > error: left shift of 15 by 28 places cannot be represented in type > 'int' >=20 > PORT_CMD_ICC_MASK is defined as >=20 > #define PORT_CMD_ICC_MASK (0xf << 28) /* i/f ICC state mask */= >=20 > which shifts into the sign bit of a signed integer. Should be fixable by using (0xfU << 28), right? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --vv6CI3pSLg9iQPA1iQnlibuh7VcqxwLXW Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVrkFOAAoJEKeha0olJ0Nq20oH/2KyR+GKdTdWmcvTVjbD6LzH ywtFqSOjZ/judA93oSm/sHPVdm1tEILz5JayLcw+gn0japrmoIqSXy7PZeLzzidx LEcYbOba6rHlP/7c9K45qgwbkV/onYbqM1PApuS4O+91/K86YGw/TX1x9lEKBt24 MOPLWKzMI3Db+gOeeT0FZzIjVpIWMyrRCS4XT2RFtWz2/mJhx1mEFzXoSmBqc6s4 8SBe2Tzhw1SzcMNKJPMISERGofwH3HDWkZx68TCoS9ptXHjmHxn0b12Ti/psbw+U QdVoqU8uQqU2gb0xz3krXY6aNGhDZQLC3d0umO8rT4xb70r2q6Qn8tXOWdwNvYU= =P5SK -----END PGP SIGNATURE----- --vv6CI3pSLg9iQPA1iQnlibuh7VcqxwLXW--