From: Eric Blake <eblake@redhat.com>
To: "Denis V. Lunev" <den@openvz.org>
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>,
Olga Krishtal <okrishtal@parallels.com>,
qemu-devel@nongnu.org, Olga Krishtal <okrishtal@virtuozzo.com>
Subject: Re: [Qemu-devel] [PATCH for-2.4 1/1] qga: fixed versions for guest bus types in qapi-schema
Date: Tue, 21 Jul 2015 08:19:49 -0600 [thread overview]
Message-ID: <55AE5505.6020409@redhat.com> (raw)
In-Reply-To: <1437481508-10166-1-git-send-email-den@openvz.org>
[-- Attachment #1: Type: text/plain, Size: 1156 bytes --]
On 07/21/2015 06:25 AM, Denis V. Lunev wrote:
> From: Olga Krishtal <okrishtal@parallels.com>
>
> Signed-off-by: Olga Krishtal <okrishtal@virtuozzo.com>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Eric Blake <eblake@redhat.com>
> CC: Michael Roth <mdroth@linux.vnet.ibm.com>
doc-only, so I've added 2.4 to the subject line.
> ---
> qga/qapi-schema.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
> index 8a9b818..b81b212 100644
> --- a/qga/qapi-schema.json
> +++ b/qga/qapi-schema.json
> @@ -714,7 +714,7 @@
> # @virtual: Win virtual bus type
> # @file-backed virtual: Win file-backed bus type
> #
> -# Since: 2.2
> +# Since: 2.2 'Unknown' and all entries below since 2.4
I would have put a comma or semicolon there for legibility:
Since: 2.2; 'Unknown' and ...
but it's minor enough that a maintainer could touch it up, or even live
with it as is, without needing a v2.
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-07-21 14:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 12:25 [Qemu-devel] [PATCH 1/1] qga: fixed versions for guest bus types in qapi-schema Denis V. Lunev
2015-07-21 14:19 ` Eric Blake [this message]
2015-07-21 19:45 ` Michael Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AE5505.6020409@redhat.com \
--to=eblake@redhat.com \
--cc=den@openvz.org \
--cc=mdroth@linux.vnet.ibm.com \
--cc=okrishtal@parallels.com \
--cc=okrishtal@virtuozzo.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).