From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36512)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1ZHYOh-0004Gk-Dc
	for qemu-devel@nongnu.org; Tue, 21 Jul 2015 10:19:56 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1ZHYOd-0002yF-5A
	for qemu-devel@nongnu.org; Tue, 21 Jul 2015 10:19:55 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50460)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <eblake@redhat.com>) id 1ZHYOc-0002yA-VZ
	for qemu-devel@nongnu.org; Tue, 21 Jul 2015 10:19:51 -0400
References: <1437481508-10166-1-git-send-email-den@openvz.org>
From: Eric Blake <eblake@redhat.com>
Message-ID: <55AE5505.6020409@redhat.com>
Date: Tue, 21 Jul 2015 08:19:49 -0600
MIME-Version: 1.0
In-Reply-To: <1437481508-10166-1-git-send-email-den@openvz.org>
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature";
	boundary="MEKjJTaMIEQODbhg4eSvkJqmO2GvE7qx8"
Subject: Re: [Qemu-devel] [PATCH for-2.4 1/1] qga: fixed versions for guest
 bus types in qapi-schema
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Denis V. Lunev" <den@openvz.org>
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>, Olga Krishtal <okrishtal@parallels.com>, qemu-devel@nongnu.org, Olga Krishtal <okrishtal@virtuozzo.com>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--MEKjJTaMIEQODbhg4eSvkJqmO2GvE7qx8
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On 07/21/2015 06:25 AM, Denis V. Lunev wrote:
> From: Olga Krishtal <okrishtal@parallels.com>
>=20
> Signed-off-by: Olga Krishtal <okrishtal@virtuozzo.com>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> CC: Eric Blake <eblake@redhat.com>
> CC: Michael Roth <mdroth@linux.vnet.ibm.com>

doc-only, so I've added 2.4 to the subject line.

> ---
>  qga/qapi-schema.json | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
> index 8a9b818..b81b212 100644
> --- a/qga/qapi-schema.json
> +++ b/qga/qapi-schema.json
> @@ -714,7 +714,7 @@
>  # @virtual: Win virtual bus type
>  # @file-backed virtual: Win file-backed bus type
>  #
> -# Since: 2.2
> +# Since: 2.2 'Unknown' and all entries below since 2.4

I would have put a comma or semicolon there for legibility:

Since: 2.2; 'Unknown' and ...

but it's minor enough that a maintainer could touch it up, or even live
with it as is, without needing a v2.

Reviewed-by: Eric Blake <eblake@redhat.com>

--=20
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


--MEKjJTaMIEQODbhg4eSvkJqmO2GvE7qx8
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Public key at http://people.redhat.com/eblake/eblake.gpg
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCAAGBQJVrlUFAAoJEKeha0olJ0NqXkgH/R7IqfwQ7tQcoocPY83DCeMH
Qb8jZ8LNnwNXZo1MaePXG3Ib4Q1PIS9GqUoJfq5qwjCzwptWy8tdxTcZ1ztfB2Hl
Di2UMIJOSta+msab0yCfoQ+zRM/2ylsTfN4JV6WTKeB1sNG8FUSQg0m60MOCj1+Q
HflCj3PIdHlxCCjbZXH5f7LTh0AxRFmMc7Cy9WoD+vGm2meRC12HT51AOiK7YrqB
SW3Hx5JDE/y1SNlxsGjIuILV57brp4fM5CCfB44HwMWroaVrqTJQez+KsLBk4yBF
djTSQvw0tT3L6Iz8K+d/llue3ZX6SZ0bMpGdS6XhLAZ8tggoHsgR5wSZYtu+arU=
=sY4b
-----END PGP SIGNATURE-----

--MEKjJTaMIEQODbhg4eSvkJqmO2GvE7qx8--