From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47002) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHaKl-00036q-PQ for qemu-devel@nongnu.org; Tue, 21 Jul 2015 12:24:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZHaKi-0002z4-Fl for qemu-devel@nongnu.org; Tue, 21 Jul 2015 12:23:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50275) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHaKi-0002z0-AL for qemu-devel@nongnu.org; Tue, 21 Jul 2015 12:23:56 -0400 References: <1435782155-31412-1-git-send-email-armbru@redhat.com> <1435782155-31412-17-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <55AE721A.1010402@redhat.com> Date: Tue, 21 Jul 2015 10:23:54 -0600 MIME-Version: 1.0 In-Reply-To: <1435782155-31412-17-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="6xBm4KAgnbIhn5V7rprghmDCtN1iu8nGE" Subject: Re: [Qemu-devel] [PATCH RFC v2 16/47] qapi-commands: Fix gen_err_check(e) for e and e != 'local_err' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, berto@igalia.com, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --6xBm4KAgnbIhn5V7rprghmDCtN1iu8nGE Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/01/2015 02:22 PM, Markus Armbruster wrote: > gen_err_check() hard-codes 'local_err' instead of substituting the > argument. Currently harmless, since all callers pass either None or > 'local_err'. >=20 > Signed-off-by: Markus Armbruster > --- > scripts/qapi-commands.py | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --6xBm4KAgnbIhn5V7rprghmDCtN1iu8nGE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVrnIaAAoJEKeha0olJ0NqKTgH/iaBO36a9oHina1bE3oRQcAp qnwsbLF3o0S6D+lQBBQXbmXu/wxDFTyLc+XPNec7E8IGOogGrTe6StEU2fxDgvGP w+7beCY+FQYl5UrRRf7RzW73I0jvsjQU9WAYBEhftpLEFhOgscxHDqMnENgrWLBC 8K9N/8XUiGG1hAKfspHP/sPn54NVkZs8T2Rw0oJ0NbZPIeZD0scBo7P2leXcU7FD bx73uzO1usqoQx823RL7MyiqmVKj2Yx/g54niTTK0dsiKxYAQBS8Mm/s7fsmkN8Z ythYRgJfWh5MkqQYokaPvPltPf4LRnzAVkHU+WL3Zj2KoOBlProJRlIUXQPd+qE= =pijY -----END PGP SIGNATURE----- --6xBm4KAgnbIhn5V7rprghmDCtN1iu8nGE--