From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34275) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHbDl-00054Z-HG for qemu-devel@nongnu.org; Tue, 21 Jul 2015 13:20:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZHbDi-00030T-25 for qemu-devel@nongnu.org; Tue, 21 Jul 2015 13:20:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36964) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHbDh-0002zx-Jx for qemu-devel@nongnu.org; Tue, 21 Jul 2015 13:20:45 -0400 References: <1435782155-31412-1-git-send-email-armbru@redhat.com> <1435782155-31412-19-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <55AE7F67.4000502@redhat.com> Date: Tue, 21 Jul 2015 11:20:39 -0600 MIME-Version: 1.0 In-Reply-To: <1435782155-31412-19-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="HsBTlkkJvKs4BG3rQUBpQrxBku2vvGHqr" Subject: Re: [Qemu-devel] [PATCH RFC v2 18/47] qapi-commands: Don't feed output of mcgen() to mcgen() again List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, berto@igalia.com, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HsBTlkkJvKs4BG3rQUBpQrxBku2vvGHqr Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/01/2015 02:22 PM, Markus Armbruster wrote: > Multiple passes through mcgen() is prone to produce unwanted blank > lines, which we then combat by sprinkling .rstrip() on top. Just > don't do it. >=20 > Signed-off-by: Markus Armbruster > --- > scripts/qapi-commands.py | 52 +++++++++++++++++++---------------------= -------- > 1 file changed, 21 insertions(+), 31 deletions(-) Reviewed-by: Eric Blake Causes the generated files to be slightly shorter (good), with diffs like the following: --- qga/qapi-generated/qga-qmp-marshal.c.old 2015-07-20 17:13:06.056297347 -0600 +++ qga/qapi-generated/qga-qmp-marshal.c 2015-07-21 11:16:09.887228043 -0600 @@ -140,7 +140,6 @@ (void)args; qmp_guest_ping(&local_err); error_propagate(errp, local_err); - } static void qmp_marshal_output_guest_get_time(int64_t ret_in, QObject **ret_out, Error **errp) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --HsBTlkkJvKs4BG3rQUBpQrxBku2vvGHqr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVrn9nAAoJEKeha0olJ0NqMngH/AqrzfUWWYkH4EwrJMV+YoSz RPvDES41jvHPrMgov99Z7qAYxAMCaojx0ZNisArIWvv8RF6zTqqp6qjOZuRaCwkg Tp6psRXcUWVsgbB4Z6Af04eGfOVfTw6U5J39Kpg7pTwtr66J2cCY3tUp06mmreQK 5XBSCSnnaexTMt0FMuwQ8w3z/E/hiAP4Qw6ATqaZmGYVvKUJmArcOpzBsp7q73f/ gbAwXQ3OeQ7t8uNHRZdtyyuKuj+LZ6Lnstm7AWJXCduwrY7KoHxNaELWyijEu8kL ssqcqyDmPCM0pTPYVjLTaOl7MCurquF1QIhKzlUP855XBo/yOVrgnLr99YjYvBE= =5+Rj -----END PGP SIGNATURE----- --HsBTlkkJvKs4BG3rQUBpQrxBku2vvGHqr--