From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49476) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHdDn-0006At-E1 for qemu-devel@nongnu.org; Tue, 21 Jul 2015 15:29:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZHdDj-0007rn-P8 for qemu-devel@nongnu.org; Tue, 21 Jul 2015 15:28:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36954) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHdDj-0007rM-Kg for qemu-devel@nongnu.org; Tue, 21 Jul 2015 15:28:55 -0400 References: <1437494626-3773-1-git-send-email-markmb@redhat.com> <1437494626-3773-2-git-send-email-markmb@redhat.com> From: Laszlo Ersek Message-ID: <55AE9D68.4050300@redhat.com> Date: Tue, 21 Jul 2015 21:28:40 +0200 MIME-Version: 1.0 In-Reply-To: <1437494626-3773-2-git-send-email-markmb@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC 1/7] fw_cfg: document fw_cfg_modify_iXX() update functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Marc_Mar=c3=ad?= , qemu-devel@nongnu.org Cc: Paolo Bonzini , "Gabriel L. Somlo" , 'Kevin O'Connor' , Gerd Hoffmann , Stefan Hajnoczi On 07/21/15 18:03, Marc Mar=ED wrote: > From: "Gabriel L. Somlo" >=20 > Document the behavior of fw_cfg_modify_iXX() for leak-less updating > of integer-type blobs. >=20 > Currently only fw_cfg_modify_i16() is coded, but 32- and 64-bit version= s > may be added later if necessary.. >=20 > Signed-off-by: Gabriel Somlo > Signed-off-by: Gerd Hoffmann > --- > docs/specs/fw_cfg.txt | 11 +++++++++++ > 1 file changed, 11 insertions(+) >=20 > diff --git a/docs/specs/fw_cfg.txt b/docs/specs/fw_cfg.txt > index 74351dd..5bc7b96 100644 > --- a/docs/specs/fw_cfg.txt > +++ b/docs/specs/fw_cfg.txt > @@ -159,6 +159,17 @@ will convert a 16-, 32-, or 64-bit integer to litt= le-endian, then add > a dynamically allocated copy of the appropriately sized item to fw_cfg > under the given selector key value. > =20 > +=3D=3D fw_cfg_modify_iXX() =3D=3D > + > +Modify the value of an XX-bit item (where XX may be 16, 32, or 64). > +Similarly to the corresponding fw_cfg_add_iXX() function set, convert > +a 16-, 32-, or 64-bit integer to little endian, create a dynamically > +allocated copy of the required size, and replace the existing item at > +the given selector key value with the newly allocated one. The previou= s > +item, assumed to have been allocated during an earlier call to > +fw_cfg_add_iXX() or fw_cfg_modify_iXX() (of the same width XX), is fre= ed > +before the function returns. > + > =3D=3D fw_cfg_add_file() =3D=3D > =20 > Given a filename (i.e., fw_cfg item name), starting pointer, and size, >=20 Reviewed-by: Laszlo Ersek