From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55088)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1ZHdbI-0000bt-6O
	for qemu-devel@nongnu.org; Tue, 21 Jul 2015 15:53:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1ZHdbE-0000kf-51
	for qemu-devel@nongnu.org; Tue, 21 Jul 2015 15:53:16 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59801)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1ZHdbE-0000kH-02
	for qemu-devel@nongnu.org; Tue, 21 Jul 2015 15:53:12 -0400
References: <1437494626-3773-1-git-send-email-markmb@redhat.com>
	<1437494626-3773-6-git-send-email-markmb@redhat.com>
	<CAJSP0QXKXW48_XPBfcT_o965CMVnWMqKSX_=OLFHdu801J+tiQ@mail.gmail.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <55AEA322.3050104@redhat.com>
Date: Tue, 21 Jul 2015 21:53:06 +0200
MIME-Version: 1.0
In-Reply-To: <CAJSP0QXKXW48_XPBfcT_o965CMVnWMqKSX_=OLFHdu801J+tiQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC 5/7] fw_cfg file sort
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>, =?UTF-8?Q?Marc_Mar=c3=ad?= <markmb@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Kevin O'Connor <kevin@koconnor.net>, qemu-devel <qemu-devel@nongnu.org>, Gerd Hoffmann <kraxel@redhat.com>

On 07/21/15 18:18, Stefan Hajnoczi wrote:
> On Tue, Jul 21, 2015 at 5:03 PM, Marc Mar=C3=AD <markmb@redhat.com> wro=
te:
>> From: Gerd Hoffmann <kraxel@redhat.com>
>>
>> This is what it takes to have a sorted fw_cfg file directory.
>> Entries are inserted at the correct place instead of being
>> appended to the end in case sorting is enabled.
>>
>> Compatibility fluff (enable sorting for new machine types only)
>> isn't there yet.
>>
>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>> ---
>>  hw/nvram/fw_cfg.c | 30 ++++++++++++++++++++++++------
>>  1 file changed, 24 insertions(+), 6 deletions(-)
>=20
> Probably best to drop this patch from this series, unless it's needed.
>=20
> I guess sorting files allows for binary search but it's unrelated to
> DMA and needs to be accompanied with guest code (e.g. SeaBIOS) that
> actually uses the feature.

I recall another discussion where the sorting was considered under a
migration aspect (not for the sake of binary search on the guest side).

.... Yes, here it is:

http://thread.gmane.org/gmane.comp.emulators.qemu/340424/focus=3D342398

The commit message should give a full rationale, preferably.

Thanks!
Laszlo