From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59491) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHgA3-0002WY-OS for qemu-devel@nongnu.org; Tue, 21 Jul 2015 18:37:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZHg9y-0008JI-UX for qemu-devel@nongnu.org; Tue, 21 Jul 2015 18:37:19 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54380) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHg9y-0008IE-NR for qemu-devel@nongnu.org; Tue, 21 Jul 2015 18:37:14 -0400 References: <1436270904-2855-1-git-send-email-stefanha@redhat.com> <1436270904-2855-4-git-send-email-stefanha@redhat.com> From: Eric Blake Message-ID: <55AEC995.5090104@redhat.com> Date: Tue, 21 Jul 2015 16:37:09 -0600 MIME-Version: 1.0 In-Reply-To: <1436270904-2855-4-git-send-email-stefanha@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="xnUUtmCaoaAwjG8Cfqw4bTxpwxMJBhQKN" Subject: Re: [Qemu-devel] [PULL for-2.4 3/7] block/nfs: add support for setting debug level List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Kevin Wolf , Peter Maydell , Peter Lieven This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --xnUUtmCaoaAwjG8Cfqw4bTxpwxMJBhQKN Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/07/2015 06:08 AM, Stefan Hajnoczi wrote: > From: Peter Lieven >=20 > upcoming libnfs versions will support logging debug messages. Add > support for it in qemu through a per-drive option. >=20 > Examples: > qemu -drive if=3Dvirtio,file=3Dnfs://...,file.debug=3D2 > qemu-img create -o debug=3D2 nfs://... 10G >=20 > Signed-off-by: Peter Lieven > Reviewed-by: Fam Zheng > Message-id: 1436251847-16875-1-git-send-email-pl@kamp.de > Signed-off-by: Stefan Hajnoczi > --- > block/nfs.c | 28 ++++++++++++++++++++++++---- > qapi/block-core.json | 20 ++++++++++++++++---- > 2 files changed, 40 insertions(+), 8 deletions(-) >=20 > +++ b/qapi/block-core.json > @@ -1381,9 +1381,9 @@ > { 'enum': 'BlockdevDriver', > 'data': [ 'archipelago', 'blkdebug', 'blkverify', 'bochs', 'cloop', > 'dmg', 'file', 'ftp', 'ftps', 'host_cdrom', 'host_device',= > - 'host_floppy', 'http', 'https', 'null-aio', 'null-co', 'pa= rallels', > - 'qcow', 'qcow2', 'qed', 'quorum', 'raw', 'tftp', 'vdi', 'v= hdx', > - 'vmdk', 'vpc', 'vvfat' ] } > + 'host_floppy', 'http', 'https', 'nfs', 'null-aio', 'null-c= o', > + 'parallels', 'qcow', 'qcow2', 'qed', 'quorum', 'raw', 'tft= p', > + 'vdi', 'vhdx', 'vmdk', 'vpc', 'vvfat' ] } Probably also ought to document the docs for BlockDeviceInfo.drv, to mention that 'nfs' was added in 2.4. [may be moot for now, since this patch was dropped when the pull request was resent; or even mean you want "2.5" when you DO add and document it] --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --xnUUtmCaoaAwjG8Cfqw4bTxpwxMJBhQKN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVrsmVAAoJEKeha0olJ0NqdrgH/1KUtFavyyUlzH05Kkf8cOeL d/8a5Pm/BfxoZFIytFYsoQtHp3pFJv0b0FZMnlTzBiJugEbShK1s65Lud40Xzltb RkH++/cWhPnReCo8Sf9DMcYvvLsaBykWakysTc4mmNJf6g5NcCei5aqjbCo5J6dL A6XupbNAjf4KIn6yaLhK40sDhC1Q4jL/LKUu5hWnrA22ajoaVSVHdhqnJla85Kkr jKMk2vRRWMLbOPkWkTOGUdIzw5xqi9/GAM/xMaIHIvV2++YO4Uz+P9dOzUqJAffa SZ7RjfMTVTiX1w76I6opBlI7FmBwRO/tfUe6UV6m1qWmBdHmrsDZZjUrTmBxPtw= =6kNu -----END PGP SIGNATURE----- --xnUUtmCaoaAwjG8Cfqw4bTxpwxMJBhQKN--