From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHqag-0006YN-Hf for qemu-devel@nongnu.org; Wed, 22 Jul 2015 05:45:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZHqaf-00076Z-4G for qemu-devel@nongnu.org; Wed, 22 Jul 2015 05:45:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35116) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZHqae-00076E-Ve for qemu-devel@nongnu.org; Wed, 22 Jul 2015 05:45:29 -0400 Message-ID: <55AF6633.5060701@redhat.com> Date: Wed, 22 Jul 2015 17:45:23 +0800 From: Jason Wang MIME-Version: 1.0 References: <1437544792-3949-1-git-send-email-jasowang@redhat.com> <1437544792-3949-3-git-send-email-jasowang@redhat.com> <20150722093145.GD12010@redhat.com> In-Reply-To: <20150722093145.GD12010@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V3 2/3] virtio-blk: fail get_features when both scsi and 1.0 were set List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: cornelia.huck@de.ibm.com, pbonzini@redhat.com, qemu-devel@nongnu.org, mst@redhat.com On 07/22/2015 05:31 PM, Daniel P. Berrange wrote: > On Wed, Jul 22, 2015 at 01:59:51PM +0800, Jason Wang wrote: >> SCSI passthrough was no longer supported in virtio 1.0, so this patch >> fail the get_features() when both 1.0 and scsi is set. And also only >> advertise VIRTIO_BLK_F_SCSI for legacy virtio-blk device. > Why is SCSI passthrough support not available in virtio 1.0 ? This > will cause a regression for any users of that as & when QEMU changes > to use virtio 1.0 by default. Can we not fix this regression instead. > > Regards, > Daniel I can find some discussion here: http://comments.gmane.org/gmane.comp.emulators.virtio.devel/865 Paolo may know more about this.