From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40555)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZHwmo-0000Ty-0Q
	for qemu-devel@nongnu.org; Wed, 22 Jul 2015 12:22:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZHwmj-0002oX-1h
	for qemu-devel@nongnu.org; Wed, 22 Jul 2015 12:22:25 -0400
References: <1437574681-18362-1-git-send-email-pbonzini@redhat.com>
	<20150722142743.GR12010@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <55AFC339.1070806@redhat.com>
Date: Wed, 22 Jul 2015 18:22:17 +0200
MIME-Version: 1.0
In-Reply-To: <20150722142743.GR12010@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] scsi: fix buffer overflow in
 scsi_req_parse_cdb (CVE-2015-5158)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org



On 22/07/2015 16:27, Daniel P. Berrange wrote:
> On Wed, Jul 22, 2015 at 04:18:00PM +0200, Paolo Bonzini wrote:
> > This is a guest-triggerable buffer overflow present in QEMU 2.2.0
> > and newer.  scsi_cdb_length returns -1 as an error value, but the
> > caller does not check it.
> > 
> > Luckily, the massive overflow means that QEMU will just SIGSEGV,
> > making the impact much smaller.
>
> FWIW, would be nice to mention which disk frontends could trigger
> this bug. eg was it all of the devices in hw/scsi/ or just a subset ?

All of them.

Paolo