From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36498) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZI9B4-0000Vs-37 for qemu-devel@nongnu.org; Thu, 23 Jul 2015 01:36:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZI9B3-0002A6-0Z for qemu-devel@nongnu.org; Thu, 23 Jul 2015 01:36:18 -0400 Received: from mail-wi0-x22b.google.com ([2a00:1450:400c:c05::22b]:32934) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZI9B2-00029v-QG for qemu-devel@nongnu.org; Thu, 23 Jul 2015 01:36:16 -0400 Received: by wicmv11 with SMTP id mv11so7867602wic.0 for ; Wed, 22 Jul 2015 22:36:16 -0700 (PDT) Sender: Paolo Bonzini References: <1437556133-11268-1-git-send-email-arei.gonglei@huawei.com> <20150722091952.GC12010@redhat.com> <20150723042249.GC11699@grmbl.mre> From: Paolo Bonzini Message-ID: <55B07D4E.9060005@redhat.com> Date: Thu, 23 Jul 2015 07:36:14 +0200 MIME-Version: 1.0 In-Reply-To: <20150723042249.GC11699@grmbl.mre> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.4] vnc: fix memory leak List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Amit Shah , "Daniel P. Berrange" , Peter Maydell Cc: arei.gonglei@huawei.com, qemu-devel@nongnu.org, kraxel@redhat.com On 23/07/2015 06:22, Amit Shah wrote: > On (Wed) 22 Jul 2015 [10:19:52], Daniel P. Berrange wrote: >> > On Wed, Jul 22, 2015 at 05:08:53PM +0800, arei.gonglei@huawei.com wrote: >>> > > From: Gonglei >>> > > >>> > > If vnc's password is configured, it will leak memory >>> > > which cipher variable pointed on every vnc connection. >>> > > >>> > > Cc: Daniel P. Berrange >>> > > Signed-off-by: Gonglei >> > >> > Reviewed-by: Daniel P. Berrange > Since Gerd is away, Peter, can you pick this up directly? I've queued it and I'll send it out for -rc3. Paolo