From: Paolo Bonzini <pbonzini@redhat.com>
To: Markus Armbruster <armbru@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 0/2] block: warn about aio=native if libaio is unavailable
Date: Thu, 23 Jul 2015 10:08:31 +0200 [thread overview]
Message-ID: <55B0A0FF.4040607@redhat.com> (raw)
In-Reply-To: <87vbdbgv1n.fsf@blackfin.pond.sub.org>
On 23/07/2015 10:03, Markus Armbruster wrote:
>
>> > v2:
>> > * Banish CONFIG_LINUX_AIO from blockdev.c, that is raw-posix.c's business
>> > [Kevin]
>> > * Print the warning in the same way as the aio=native,cache.direct=off
>> > deprecation warning [Kevin]
>> >
>> > Open question: what about the Windows case? We now pass the
>> > FILE_FLAG_OVERLAPPED flag which we didn't do before for -drive aio=native.
> Odd. Commit a273652 takes the trouble to implement native asynchronous
> I/O there, but unless CONFIG_LINUX_AIO somehow gets defined, it's
> unreachable, isn't it? Paolo?
I don't remember how I tested that code, but it's probably been dead
code since it was committed. If it's bitrot and thus these patches
break it, I will fix it.
Paolo
> I think PATCH 2's commit message needs to be updated to discuss the
> impact.
next prev parent reply other threads:[~2015-07-23 9:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-17 14:23 [Qemu-devel] [PATCH v2 0/2] block: warn about aio=native if libaio is unavailable Stefan Hajnoczi
2015-07-17 14:23 ` [Qemu-devel] [PATCH v2 1/2] raw-posix: warn about BDRV_O_NATIVE_AIO " Stefan Hajnoczi
2015-07-23 10:09 ` Christian Borntraeger
2015-07-23 10:11 ` Denis V. Lunev
2015-07-23 11:58 ` Kevin Wolf
2015-07-17 14:23 ` [Qemu-devel] [PATCH v2 2/2] blockdev: always compile in -drive aio= parsing Stefan Hajnoczi
2015-07-23 7:58 ` Markus Armbruster
2015-07-23 8:03 ` [Qemu-devel] [PATCH v2 0/2] block: warn about aio=native if libaio is unavailable Markus Armbruster
2015-07-23 8:08 ` Paolo Bonzini [this message]
2015-07-23 8:15 ` Kevin Wolf
2015-07-23 12:06 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B0A0FF.4040607@redhat.com \
--to=pbonzini@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).