From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51774) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZICvr-0002gs-2a for qemu-devel@nongnu.org; Thu, 23 Jul 2015 05:36:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZICvm-0001IJ-4Y for qemu-devel@nongnu.org; Thu, 23 Jul 2015 05:36:51 -0400 References: <1437143029-12100-1-git-send-email-stefanha@redhat.com> <87vbdbgv1n.fsf@blackfin.pond.sub.org> From: Paolo Bonzini Message-ID: <55B0A0FF.4040607@redhat.com> Date: Thu, 23 Jul 2015 10:08:31 +0200 MIME-Version: 1.0 In-Reply-To: <87vbdbgv1n.fsf@blackfin.pond.sub.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/2] block: warn about aio=native if libaio is unavailable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , Stefan Hajnoczi Cc: Kevin Wolf , qemu-devel@nongnu.org, qemu-block@nongnu.org On 23/07/2015 10:03, Markus Armbruster wrote: > >> > v2: >> > * Banish CONFIG_LINUX_AIO from blockdev.c, that is raw-posix.c's business >> > [Kevin] >> > * Print the warning in the same way as the aio=native,cache.direct=off >> > deprecation warning [Kevin] >> > >> > Open question: what about the Windows case? We now pass the >> > FILE_FLAG_OVERLAPPED flag which we didn't do before for -drive aio=native. > Odd. Commit a273652 takes the trouble to implement native asynchronous > I/O there, but unless CONFIG_LINUX_AIO somehow gets defined, it's > unreachable, isn't it? Paolo? I don't remember how I tested that code, but it's probably been dead code since it was committed. If it's bitrot and thus these patches break it, I will fix it. Paolo > I think PATCH 2's commit message needs to be updated to discuss the > impact.