From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44896) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZIEN5-00029C-8i for qemu-devel@nongnu.org; Thu, 23 Jul 2015 07:09:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZIEN0-0008Cw-1V for qemu-devel@nongnu.org; Thu, 23 Jul 2015 07:09:03 -0400 Received: from mail-wi0-x231.google.com ([2a00:1450:400c:c05::231]:35370) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZIEMz-0008BL-QP for qemu-devel@nongnu.org; Thu, 23 Jul 2015 07:08:57 -0400 Received: by wibxm9 with SMTP id xm9so203140665wib.0 for ; Thu, 23 Jul 2015 04:08:57 -0700 (PDT) Sender: Paolo Bonzini References: <1437574681-18362-2-git-send-email-pbonzini@redhat.com> <55B0C24C.7020401@de.ibm.com> <55B0C527.8060502@redhat.com> <55B0CA2D.3060506@cn.fujitsu.com> From: Paolo Bonzini Message-ID: <55B0CB47.2070301@redhat.com> Date: Thu, 23 Jul 2015 13:08:55 +0200 MIME-Version: 1.0 In-Reply-To: <55B0CA2D.3060506@cn.fujitsu.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] rcu: actually register threads that have RCU read-side critical sections List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wen Congyang , Christian Borntraeger , qemu-devel@nongnu.org On 23/07/2015 13:04, Wen Congyang wrote: > > Yes. I think this is better for 2.4. There are threads that do not > > need RCU, for example the thread-pool.c worker threads, so it may just > > If the thread doesn't use RCU, rcu_register_thread() is harmless, is it right? Every rcu_register_thread() makes synchronize_rcu() a little slower. >> > be simpler to add an assertion in rcu_register_thread. I'm just a bit >> > wary of doing little more than the bare minimum in 2.4, because of the >> > OS X failure that I didn't quite understand. > Which problem? I don't find it in the maillist. http://article.gmane.org/gmane.comp.emulators.qemu/351548 Paolo