From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Keith Busch <keith.busch@intel.com>,
Kevin Wolf <kwolf@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-block@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH 0/5] replace qemu_fls() with pow2ceil()/pow2floor()
Date: Thu, 23 Jul 2015 13:09:57 +0200 [thread overview]
Message-ID: <55B0CB85.6020903@redhat.com> (raw)
In-Reply-To: <1437649738-13885-1-git-send-email-peter.maydell@linaro.org>
On 23/07/2015 13:08, Peter Maydell wrote:
> We have a qemu_fls() function which is just a silly wrapper
> around clz32() and which is used in only a handful of places
> in the codebase. It turns out that all of those are really
> trying to round up or down to a power of 2, which is something
> we have utility functions for. This series replaces all
> the qemu_fls() calls with pow2ceil() or pow2floor(), and then
> removes the now-unused function.
>
> For the case where you really want to do bit counting rather
> than just power-of-2 rounding, you should use the clz/clo
> functions directly.
>
> (I've set myself a little goal of "try to do one cleanup a
> day"; that may be a bit ambitious, so we'll see...)
If it turns out to be ambitious, even just "record one cleanup a day in
BiteSizedTasks" would be awesome.
Paolo
next prev parent reply other threads:[~2015-07-23 11:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 11:08 [Qemu-devel] [PATCH 0/5] replace qemu_fls() with pow2ceil()/pow2floor() Peter Maydell
2015-07-23 11:08 ` [Qemu-devel] [PATCH 1/5] hw/pci: Use pow2ceil() rather than hand-calculation Peter Maydell
2015-07-23 11:08 ` [Qemu-devel] [PATCH 2/5] hw/virtio/virtio-pci: " Peter Maydell
2015-07-23 11:08 ` [Qemu-devel] [PATCH 3/5] hw/block/nvme.c: " Peter Maydell
2015-07-23 11:08 ` [Qemu-devel] [PATCH 4/5] exec.c: Use pow2floor() " Peter Maydell
2015-07-23 11:08 ` [Qemu-devel] [PATCH 5/5] Remove unused qemu_fls function Peter Maydell
2015-07-23 11:09 ` Paolo Bonzini [this message]
2015-07-23 16:54 ` [Qemu-devel] [PATCH 0/5] replace qemu_fls() with pow2ceil()/pow2floor() Paolo Bonzini
2015-07-23 20:10 ` Peter Maydell
2015-07-24 5:10 ` Paolo Bonzini
2015-07-24 8:39 ` Peter Maydell
2015-07-24 8:48 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B0CB85.6020903@redhat.com \
--to=pbonzini@redhat.com \
--cc=keith.busch@intel.com \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).