From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42848) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZIKVL-0000qQ-O4 for qemu-devel@nongnu.org; Thu, 23 Jul 2015 13:42:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZIKVI-0005wf-Gm for qemu-devel@nongnu.org; Thu, 23 Jul 2015 13:41:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:54526) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZIKVI-0005wO-AV for qemu-devel@nongnu.org; Thu, 23 Jul 2015 13:41:56 -0400 References: <1435782155-31412-1-git-send-email-armbru@redhat.com> <1435782155-31412-36-git-send-email-armbru@redhat.com> From: Eric Blake Message-ID: <55B1275C.3000305@redhat.com> Date: Thu, 23 Jul 2015 11:41:48 -0600 MIME-Version: 1.0 In-Reply-To: <1435782155-31412-36-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2AWL56VfP61KOJaoo4fmgAHc6Rcm0Qhkm" Subject: Re: [Qemu-devel] [PATCH RFC v2 35/47] qapi-commands: Rearrange code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, berto@igalia.com, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2AWL56VfP61KOJaoo4fmgAHc6Rcm0Qhkm Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 07/01/2015 02:22 PM, Markus Armbruster wrote: > Rename gen_marshal_input() to gen_marshal(), because the generated > function marshals both arguments and results. >=20 > Rename gen_visitor_input_containers_decl() to gen_marshal_vars(), and > move the other variable declarations there, too. >=20 > Rename gen_visitor_input_block()() to gen_marshal_input_visit(), and Double (). > rearrange its code slightly. >=20 > Rename gen_marshal_input_decl() to gen_marshal_proto(), because the > result isn't a full declaration, unlike gen_command_decl()'s. >=20 > New gen_marshal_decl() actually returns a full declaration. No change to generated code; good. >=20 > Signed-off-by: Markus Armbruster > --- > scripts/qapi-commands.py | 95 ++++++++++++++++++++++------------------= -------- > 1 file changed, 43 insertions(+), 52 deletions(-) >=20 > push_indent() > + > + if rets: > + # FIXME fishy: only pointers are initialized > + if rets.c_null() =3D=3D 'NULL': > + retval =3D '%s retval =3D NULL;' % rets.c_type() > + else: > + retval =3D '%s retval;' % rets.c_type() May still need tweaking based on my earlier reviews. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --2AWL56VfP61KOJaoo4fmgAHc6Rcm0Qhkm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVsSdcAAoJEKeha0olJ0NqOb0H/jWfZcMS+Qo9mZbYbEtwAN84 KRocT+7VLEIi3Myos11wx6GDcYapcDD+JXyEjbMgcuzybHfat1SFZxZIzFm3mUiH cX3szS6WTgulvg/DwjR3/Y0/loz97cRaUTPQRUOJg0v2w8ZTYOeM2nDNGAEqhFAt 2EDEF6FVr1Mol72UZm4Om5cfW5M/nzD/vLHQp4Pr4yKc5l0kiJVvGYMI/gj0CvMR pky0z8PZqHP8M8ZXWBPyQ5qlI116vco9Tsc4Pl+rziVzWrzPe1gOpfcOFOeSJ3RA 3aZlsLcfha8xk1WW53RmgMHTv3rpnqnNC5/HVZF0e5oCmKb94gfPsVnjAMw+Bq8= =JHW2 -----END PGP SIGNATURE----- --2AWL56VfP61KOJaoo4fmgAHc6Rcm0Qhkm--