qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PULL v3 00/12] Final changes for 2.4-rc0
Date: Fri, 24 Jul 2015 16:15:31 +0200	[thread overview]
Message-ID: <55B24883.3060406@redhat.com> (raw)
In-Reply-To: <20150724141449.GR6880@redhat.com>



On 24/07/2015 16:14, Daniel P. Berrange wrote:
>> > diff --git a/Makefile.objs b/Makefile.objs
>> > index f094eff..9d988d9 100644
>> > --- a/Makefile.objs
>> > +++ b/Makefile.objs
>> > @@ -2,7 +2,9 @@
>> >  # Common libraries for tools and emulators
>> >  stub-obj-y = stubs/
>> >  util-obj-y = util/ qobject/ qapi/ qapi-types.o qapi-visit.o qapi-event.o
>> > -util-obj-y += crypto/
>> > +
>> > +util-obj-$(call notempty,$(TOOLS)) += crypto/
>> > +util-obj-$(CONFIG_SOFTMMU) += crypto/
> I have a feeling that'd cause the test suite to fail to link,
> because it expects it to be unconditionally present in the
> libqemuutil.a lib.

Right...  We need to introduce CONFIG_CRYPTO and use it in
tests/Makefile too.

Paolo

  reply	other threads:[~2015-07-24 14:15 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-08 11:19 [Qemu-devel] [PULL v3 00/12] Final changes for 2.4-rc0 Paolo Bonzini
2015-07-08 14:46 ` Peter Maydell
2015-07-08 15:21   ` Paolo Bonzini
2015-07-08 15:48     ` Peter Maydell
2015-07-08 17:06       ` Paolo Bonzini
2015-07-08 18:03         ` Peter Maydell
2015-07-24 12:52       ` Daniel P. Berrange
2015-07-24 12:53         ` Paolo Bonzini
2015-07-24 13:00           ` Peter Maydell
2015-07-24 13:02             ` Paolo Bonzini
2015-07-24 13:06             ` Peter Maydell
2015-07-24 13:10               ` Daniel P. Berrange
2015-07-24 13:31                 ` Peter Maydell
2015-07-24 13:48                   ` Daniel P. Berrange
2015-07-24 13:50                     ` Paolo Bonzini
2015-07-24 13:55                   ` Paolo Bonzini
2015-07-24 14:14                     ` Daniel P. Berrange
2015-07-24 14:15                       ` Paolo Bonzini [this message]
2015-07-24 14:19                         ` Daniel P. Berrange
2015-07-24 14:21                           ` Paolo Bonzini
2015-07-24 14:25                     ` Peter Maydell
2015-07-24 15:09                       ` Peter Maydell
2015-07-08 20:48 ` Peter Maydell
2015-07-09  7:02   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B24883.3060406@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=berrange@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).