From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50101)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZIdlE-0006hw-2s
	for qemu-devel@nongnu.org; Fri, 24 Jul 2015 10:15:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZIdl9-0001n1-Vw
	for qemu-devel@nongnu.org; Fri, 24 Jul 2015 10:15:40 -0400
Received: from mx1.redhat.com ([209.132.183.28]:45767)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZIdl9-0001mq-Pj
	for qemu-devel@nongnu.org; Fri, 24 Jul 2015 10:15:35 -0400
References: <CAFEAcA9h8uaJF4c9MAYus64LLt+s23KBJwzxrpYdn4keB_GVTQ@mail.gmail.com>
	<559D4011.1010302@redhat.com>
	<CAFEAcA_EDfhFQKkbnGo3tXaj3hQ+uQkQnXdQ8p=bmD-S1_ej8g@mail.gmail.com>
	<20150724125238.GA12473@redhat.com> <55B23556.2080302@redhat.com>
	<CAFEAcA8f2x5R5ujVzB8bviYDGzMwz+WFCg9=PsZRWPjf6zV_qQ@mail.gmail.com>
	<CAFEAcA-ojp-9kTocUTJnfP8W4b01zQxS-2Ew9TY7UXGkzwhSNQ@mail.gmail.com>
	<20150724131002.GM6880@redhat.com>
	<CAFEAcA_bSsmkrMAvArXhYs=cs-ESJQwC1+aH4=L6vk9a4NDc-A@mail.gmail.com>
	<55B243EC.2060406@redhat.com> <20150724141449.GR6880@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <55B24883.3060406@redhat.com>
Date: Fri, 24 Jul 2015 16:15:31 +0200
MIME-Version: 1.0
In-Reply-To: <20150724141449.GR6880@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL v3 00/12] Final changes for 2.4-rc0
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>



On 24/07/2015 16:14, Daniel P. Berrange wrote:
>> > diff --git a/Makefile.objs b/Makefile.objs
>> > index f094eff..9d988d9 100644
>> > --- a/Makefile.objs
>> > +++ b/Makefile.objs
>> > @@ -2,7 +2,9 @@
>> >  # Common libraries for tools and emulators
>> >  stub-obj-y = stubs/
>> >  util-obj-y = util/ qobject/ qapi/ qapi-types.o qapi-visit.o qapi-event.o
>> > -util-obj-y += crypto/
>> > +
>> > +util-obj-$(call notempty,$(TOOLS)) += crypto/
>> > +util-obj-$(CONFIG_SOFTMMU) += crypto/
> I have a feeling that'd cause the test suite to fail to link,
> because it expects it to be unconditionally present in the
> libqemuutil.a lib.

Right...  We need to introduce CONFIG_CRYPTO and use it in
tests/Makefile too.

Paolo