From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52257)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZIdqh-0001t4-LY
	for qemu-devel@nongnu.org; Fri, 24 Jul 2015 10:21:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZIdqd-0004Ha-BE
	for qemu-devel@nongnu.org; Fri, 24 Jul 2015 10:21:19 -0400
Received: from mx1.redhat.com ([209.132.183.28]:38015)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1ZIdqd-0004HQ-6I
	for qemu-devel@nongnu.org; Fri, 24 Jul 2015 10:21:15 -0400
References: <CAFEAcA_EDfhFQKkbnGo3tXaj3hQ+uQkQnXdQ8p=bmD-S1_ej8g@mail.gmail.com>
	<20150724125238.GA12473@redhat.com> <55B23556.2080302@redhat.com>
	<CAFEAcA8f2x5R5ujVzB8bviYDGzMwz+WFCg9=PsZRWPjf6zV_qQ@mail.gmail.com>
	<CAFEAcA-ojp-9kTocUTJnfP8W4b01zQxS-2Ew9TY7UXGkzwhSNQ@mail.gmail.com>
	<20150724131002.GM6880@redhat.com>
	<CAFEAcA_bSsmkrMAvArXhYs=cs-ESJQwC1+aH4=L6vk9a4NDc-A@mail.gmail.com>
	<55B243EC.2060406@redhat.com> <20150724141449.GR6880@redhat.com>
	<55B24883.3060406@redhat.com> <20150724141952.GS6880@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <55B249D6.5060509@redhat.com>
Date: Fri, 24 Jul 2015 16:21:10 +0200
MIME-Version: 1.0
In-Reply-To: <20150724141952.GS6880@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PULL v3 00/12] Final changes for 2.4-rc0
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>



On 24/07/2015 16:19, Daniel P. Berrange wrote:
>> > Right...  We need to introduce CONFIG_CRYPTO and use it in
>> > tests/Makefile too.
> Except it was a goal of this work that we do not have such config
> parameters leak outside to callers.

CONFIG_CRYPTO would disable all of crypto/ if neither tools nor system
emulators are compiled (e.g. using $(call lor) and $(call notempty)).
It would be an internal detail of the Makefile.

Paolo

> The intent was that the APIs
> are always built-in - we just conditionally disable the internal
> implementation, so that code using these APIs does not need to
> deal with conditionally disabling itself like this. It is
> preferrable to just fix disablement of gnutls IMHO.