From: Richard Henderson <rth@twiddle.net>
To: Aurelien Jarno <aurelien@aurel32.net>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-2.4] tcg: correctly mark dead inputs for mov with a constant
Date: Sat, 25 Jul 2015 15:06:03 -0700 [thread overview]
Message-ID: <55B4084B.4060804@twiddle.net> (raw)
In-Reply-To: <1437780852-1549-1-git-send-email-aurelien@aurel32.net>
On 07/24/2015 04:34 PM, Aurelien Jarno wrote:
> ots->val_type = TEMP_VAL_CONST;
> ots->val = ts->val;
> + if (IS_DEAD_ARG(1)) {
> + temp_dead(s, args[1]);
> + }
Aren't we also missing
if (NEED_SYNC_ARG(0)) {
temp_sync(s, args[0], allocated_regs);
}
along this path? Seems like there's room for cleanup here, at least for 2.5...
r~
next prev parent reply other threads:[~2015-07-25 22:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 23:34 [Qemu-devel] [PATCH for-2.4] tcg: correctly mark dead inputs for mov with a constant Aurelien Jarno
2015-07-25 22:06 ` Richard Henderson [this message]
2015-07-25 22:51 ` Aurelien Jarno
2015-07-25 23:12 ` Richard Henderson
2015-07-26 15:59 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B4084B.4060804@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).